fix: support non interactive tty when deploying #7640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 7c1de03
|
eduardoboucas approved these changes Sep 24, 2025
src/commands/deploy/deploy.ts Outdated
| import { parseAllHeaders } from '@netlify/headers-parser' | ||
| import { parseAllRedirects } from '@netlify/redirect-parser' | ||
| import prettyjson from 'prettyjson' | ||
| import { stdin, stdout } from 'process' |
There was a problem hiding this comment.
nit: Move this to the top, near the other built-in imports.
src/commands/deploy/deploy.ts Outdated
Comment on lines 123 to 125
| // non interactive - can't get the value, resolve to the cwd | ||
| deployFolder = command.workspacePackage ? command.jsWorkspaceRoot || site.root : command.workingDir | ||
| return deployFolder || command.workingDir |
There was a problem hiding this comment.
nit: I personally find the nesting of conditionals quite confusing and would prefer a more explicit version, even if more verbose. Up to you, though.
Suggested change
| // non interactive - can't get the value, resolve to the cwd | |
| deployFolder = command.workspacePackage ? command.jsWorkspaceRoot || site.root : command.workingDir | |
| return deployFolder || command.workingDir | |
| if (command.workspacePackage) { | |
| if (command.jsWorkspaceRoot) { | |
| return command.jsWorkspaceRoot | |
| } | |
| if (site.root) { | |
| return site.root | |
| } | |
| } | |
| // Either not a workspace package, or empty site root. | |
| return command.workingDir |
| } | ||
| | ||
| if (!deployFolder) { | ||
| if (!stdin.isTTY || !stdout.isTTY) { |
There was a problem hiding this comment.
nit: Might be nice to abstract this to a isInteractive method that we use in the different places we're checking this to ensure consistent behaviour. I could also see us introducing an explicit flag to control this behaviour (similar to npm's --yes) and that would make it easier to integrate. Not a blocker, though.
VitaliyR force-pushed the vitaliir/EX-833 branch from 70c19c8 to a8f382a Compare eduardoboucas approved these changes Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Adds support for non interactive TTY when running
netlify deployFor us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)