feat!: drop support for node 18.x and 19.x #7332
Conversation
📊 Benchmark resultsComparing with 8bb3fd2
|
| }) | ||
| | ||
| test.runIf(gte(version, '18.14.0'))('should support functions with streaming responses', async (t) => { | ||
| test.runIf(gte(version, '20.12.2'))('should support functions with streaming responses', async (t) => { |
There was a problem hiding this comment.
I don't think we need this anymore because now the lowest version we test with has support for Request/Response, which is what this condition was about.
| test.runIf(gte(version, '20.12.2'))('should support functions with streaming responses', async (t) => { | |
| test('should support functions with streaming responses', async (t) => { |
| } | ||
| | ||
| describe.runIf(gte(version, '18.13.0')).concurrent('v2 api', async () => { | ||
| describe.runIf(gte(version, '20.12.2')).concurrent('v2 api', async () => { |
There was a problem hiding this comment.
I don't think we need this anymore because now the lowest version we test with has support for Request/Response, which is what this condition was about.
| describe.runIf(gte(version, '20.12.2')).concurrent('v2 api', async () => { | |
| describe.concurrent('v2 api', async () => { |
| | ||
| const TYPESCRIPT_EXTENSIONS = new Set(['.cts', '.mts', '.ts']) | ||
| const V2_MIN_NODE_VERSION = '18.14.0' | ||
| const V2_MIN_NODE_VERSION = '20.12.2' |
There was a problem hiding this comment.
This is technically not needed, since the minimum version needed to have V2 functions (with Request/Response) is still the same. It just happens that this version is now lower than the minimum version supported by the CLI.
This means that this constant and the isSupported() method that uses it can go away. But we can do that in a follow-up.
2 participants
🎉 Thanks for submitting a pull request! 🎉
Summary
This removes support for node 18.x and 19.x
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)