fix(command-dev): pass full lambda-local result functions server #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with bbb78bd Package size: 330 MB(no change) Legend
|
erezrokah commented Jul 11, 2021
| }) | ||
| | ||
| return { body, statusCode } | ||
| return result |
There was a problem hiding this comment.
We can also pass just the stuff we're expecting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
- Summary
Follow up on #2826
Fixes an issue where functions headers from
lambda-localare not passed down to the functions server.Found it while reviewing #2852
- Test plan
Added a test case for it
- A picture of a cute animal (not mandatory but encouraged)
🐪