Skip to content

Conversation

erezrokah
Copy link
Contributor

- Summary

Fixes #2882 which is a regression because of #2842
If we see more cases I'll revert that PR

- Test plan

Tested manually

- A picture of a cute animal (not mandatory but encouraged)
🐟

@erezrokah erezrokah requested a review from a team as a code owner July 8, 2021 14:30
@erezrokah erezrokah requested a review from eduardoboucas July 8, 2021 14:30
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jul 8, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

📊 Benchmark results

Comparing with 5ff47c9

Package size: 329 MB

(no change)

^ 331 MB 331 MB 331 MB 331 MB 331 MB 331 MB 331 MB 331 MB 329 MB 329 MB 330 MB 330 MB 329 MB │ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| └───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──> T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T 
Legend
@erezrokah erezrokah enabled auto-merge (squash) July 8, 2021 14:31
@erezrokah erezrokah merged commit 77c32cd into main Jul 8, 2021
@erezrokah erezrokah deleted the fix/vite branch July 8, 2021 14:49
@unclejustin
Copy link

@erezrokah thanks for jumping on this so quickly! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug code to address defects in shipped code

3 participants