refactor(command-dev): use execa to launch framework server #2857

erezrokah · 2021-07-06T14:49:28Z

- Summary

Related to #1704

Switches to using execa when launching the framework server to make it easier to know when the process exits.

- Test plan

Existing tests + added a test for a specific use case when the command doesn't exists.
I'll also verify with various frameworks.

- A picture of a cute animal (not mandatory but encouraged)
🐟

github-actions · 2021-07-06T14:50:25Z

📊 Benchmark results

Comparing with d451cb3

Package size: 330 MB

(no change)

^ 329 MB 329 MB 331 MB 331 MB 331 MB 331 MB 329 MB 329 MB 329 MB 329 MB 329 MB 329 MB 330 MB │ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ ┌──┐ │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| │ | | | | | | | | | | | | | | | | | | | | | | | | |▒▒| └───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──> T-12 T-11 T-10 T-9 T-8 T-7 T-6 T-5 T-4 T-3 T-2 T-1 T

Legend

T-30 (d451cb3): 330 MB
T-29 (c381072): 330 MB
T-28 (537b760): 330 MB
T-27 (172c955): 330 MB
T-26 (259dd5f): 330 MB
T-25 (9f41225): 330 MB
T-24 (9f0ff3f): 329 MB
T-23 (70ddcca): 329 MB
T-22 (88df4e0): 329 MB
T-21 (3897234): 329 MB
T-20 (a378a98): 329 MB
T-19 (39eaeb3): 329 MB
T-18 (fd58db1): 329 MB
T-17 (77c32cd): 329 MB
T-16 (5ff47c9): 329 MB
T-15 (129e434): 329 MB
T-14 (f289cbd): 329 MB
T-13 (9072cc9): 329 MB
T-12 (202596e): 329 MB
T-11 (1d975d6): 329 MB
T-10 (11b2d1b): 331 MB
T-9 (428d46c): 331 MB
T-8 (ff7ff6a): 331 MB
T-7 (41ff459): 331 MB
T-6 (98c6667): 329 MB
T-5 (4d0a89c): 329 MB
T-4 (e1a091f): 329 MB
T-3 (03d79c6): 329 MB
T-2 (6ee72fa): 329 MB
T-1 (9f5c12b): 329 MB
T (current commit): 330 MB

src/commands/dev/index.js

tests/framework-detection.test.js

src/commands/dev/index.js

erezrokah · 2021-07-08T18:07:00Z

tests/snapshots/framework-detection.test.js.md

 > react-scripts start␊
 ␊
- ◈ "npm start" exited with code *. Shutting down Netlify Dev server`
+ ◈ Failed launching framework server. Please verify 'npm' exists`


This doesn't look good. Looking into it

Fixed in f41e5b1

erezrokah added the type: chore work needed to keep the product and development running smoothly label Jul 6, 2021

erezrokah commented Jul 6, 2021

View reviewed changes

src/commands/dev/index.js Show resolved Hide resolved

erezrokah force-pushed the refactor/use_execa_framework branch from a90c35e to e1518cf Compare July 7, 2021 17:15

erezrokah commented Jul 8, 2021

View reviewed changes

tests/framework-detection.test.js Show resolved Hide resolved

erezrokah marked this pull request as ready for review July 8, 2021 13:16

erezrokah requested a review from a team as a code owner July 8, 2021 13:16

erezrokah requested a review from ehmicky July 8, 2021 13:16