test: add cases for monorepo and build plugins with siteDependencies constraints

Author: pieh

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_hoisted/apps/web/netlify.toml

@@ -0,0 +1,2 @@
+[[plugins]]
+package = "netlify-plugin-contextual-env"

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_hoisted/apps/web/package.json

@@ -0,0 +1,11 @@
+{
+ "name": "module_plugin",
+ "version": "0.0.1",
+ "type": "module",
+ "description": "test",
+ "license": "MIT",
+ "repository": "test",
+ "dependencies": {
+ "@netlify/dependency-with-range": "^9.5.4"
+ }
+}

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_hoisted/node_modules/@netlify/dependency-with-range/package.json

@@ -0,0 +1,5 @@
+{
+ "workspaces": [
+ "apps/*"
+ ]
+}

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_hoisted/package.json

@@ -0,0 +1,2 @@
+[[plugins]]
+package = "netlify-plugin-contextual-env"

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_not_hoisted/apps/web/netlify.toml

@@ -0,0 +1,11 @@
+{
+ "name": "module_plugin",
+ "version": "0.0.1",
+ "type": "module",
+ "description": "test",
+ "license": "MIT",
+ "repository": "test",
+ "dependencies": {
+ "@netlify/dependency-with-range": "^9.5.4"
+ }
+}

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_not_hoisted/apps/web/node_modules/@netlify/dependency-with-range/package.json

@@ -0,0 +1,5 @@
+{
+ "workspaces": [
+ "apps/*"
+ ]
+}

packages/build/tests/plugins_list/fixtures/plugins_compat_site_dependencies_range_monorepo_not_hoisted/apps/web/package.json

@@ -8,8 +8,7 @@ import cpy from 'cpy'
 
 const FIXTURES_DIR = fileURLToPath(new URL('fixtures', import.meta.url))
 
-const runWithApiMock = async function (
- t,
+const runWithApiMockAndGetNormalizedOutput = async function (
  fixtureName,
  { testPlugin, response = getPluginsList(testPlugin), ...flags } = {},
  status = 200,
@@ -20,18 +19,29 @@ const runWithApiMock = async function (
  status,
  })
  try {
- const output = await new Fixture(`./fixtures/${fixtureName}`)
+ const fixture = new Fixture(`./fixtures/${fixtureName}`)
+ const output = await fixture
  .withFlags({
  testOpts: { pluginsListUrl: `${scheme}://${host}`, ...flags.testOpts },
+ // cwd: fixture.repositoryRoot,
  ...flags,
  })
  .runWithBuild()
- await t.snapshot(normalizeOutput(output))
+ return normalizeOutput(output)
  } finally {
  await stopServer()
  }
 }
 
+const runWithApiMock = async function (
+ t,
+ fixtureName,
+ { testPlugin, response = getPluginsList(testPlugin), ...flags } = {},
+ status = 200,
+) {
+ await t.snapshot(await runWithApiMockAndGetNormalizedOutput(fixtureName, { testPlugin, response, ...flags }, status))
+}
+
 // We use a specific plugin in tests. We hardcode its version to keep the tests
 // stable even when new versions of that plugin are published.
 const getPluginsList = function (testPlugin = DEFAULT_TEST_PLUGIN) {
@@ -289,6 +299,66 @@ test.serial('Plugins can specify non-matching compatibility.siteDependencies ran
  })
 })
 
+test.serial(
+ 'Plugins can specify matching compatibility.siteDependencies range in monorepo with hoisted node_modules',
+ async (t) => {
+ await removeDir(`${FIXTURES_DIR}/plugins_compat_site_dependencies_range_monorepo_hoisted/apps/web/.netlify`)
+ const normalizedOutput = await runWithApiMockAndGetNormalizedOutput(
+ 'plugins_compat_site_dependencies_range_monorepo_hoisted',
+ {
+ testPlugin: {
+ compatibility: [
+ { version: '0.3.0' },
+ {
+ version: '0.2.0',
+ siteDependencies: {
+ // this is satisfied, so this version should be selected
+ '@netlify/dependency-with-range': '<10',
+ },
+ },
+ ],
+ },
+ packagePath: 'apps/web',
+ },
+ )
+ t.true(
+ normalizedOutput.includes(
+ 'netlify-plugin-contextual-env 0-2-0 from netlify.toml (latest 0-3-0, expected 0-2-0, compatible 0-2-0)',
+ ),
+ )
+ },
+)
+
+test.serial(
+ 'Plugins can specify matching compatibility.siteDependencies range in monorepo without hoisted node_modules',
+ async (t) => {
+ await removeDir(`${FIXTURES_DIR}/plugins_compat_site_dependencies_range_monorepo_not_hoisted/apps/web/.netlify`)
+ const normalizedOutput = await runWithApiMockAndGetNormalizedOutput(
+ 'plugins_compat_site_dependencies_range_monorepo_not_hoisted',
+ {
+ testPlugin: {
+ compatibility: [
+ { version: '0.3.0' },
+ {
+ version: '0.2.0',
+ siteDependencies: {
+ // this is satisfied, so this version should be selected
+ '@netlify/dependency-with-range': '<10',
+ },
+ },
+ ],
+ },
+ packagePath: 'apps/web',
+ },
+ )
+ t.true(
+ normalizedOutput.includes(
+ 'netlify-plugin-contextual-env 0-2-0 from netlify.toml (latest 0-3-0, expected 0-2-0, compatible 0-2-0)',
+ ),
+ )
+ },
+)
+
 test.serial('Plugin versions can be feature flagged', async (t) => {
  await removeDir(`${FIXTURES_DIR}/plugins_compat_node_version/.netlify`)
  await runWithApiMock(t, 'plugins_compat_node_version', {