[12.x] use limit() in place of take() #56080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
in all of these changes, `take()` is a direct alias of the `limit()` method, and performs no additional logic. switching to directly calling the `limit()` method means less code execution (minimallly better performance) and reduces the call stack (nice for debugging). a bit more subjective, but I would also argue that "limit" is a little clearer semantically about what it is doing to the query, whereas "take" has the implication that you're selecting everything and then taking a subset of that result.
This was referenced Jun 19, 2025
Contributor
| In a quick GitHub search, I think we have more |
Contributor Author
| are you sure they are specifically |
Contributor
| Apologies, I double-checked, and these are not calls from the |
mohammad-fouladgar pushed a commit to mohammad-fouladgar/framework that referenced this pull request Jul 22, 2025
* use `limit()` in place of `take()` in all of these changes, `take()` is a direct alias of the `limit()` method, and performs no additional logic. switching to directly calling the `limit()` method means less code execution (minimallly better performance) and reduces the call stack (nice for debugging). a bit more subjective, but I would also argue that "limit" is a little clearer semantically about what it is doing to the query, whereas "take" has the implication that you're selecting everything and then taking a subset of that result. * fix test mock --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
in all of these changes,
take()is a direct alias of thelimit()method, and performs no additional logic. switching to directly calling thelimit()method means less code execution (minimallly better performance) and reduces the call stack (nice for debugging).a bit more subjective, but I would also argue that "limit" is a little clearer semantically about what it is doing to the query, whereas "take" has the implication that you're selecting everything and then taking a subset of that result.