Skip to content

[11.x] fix PHPDoc for \Illuminate\Database\Connection #53212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2024
Merged

[11.x] fix PHPDoc for \Illuminate\Database\Connection #53212

merged 2 commits into from
Oct 18, 2024

Conversation

@taka-oyama
Copy link
Contributor

@taka-oyama taka-oyama commented Oct 18, 2024 •
edited
Loading

$events and $transactionsManager can both be set to null using unsetEventDispatcher() and unsetTransactionManager.

As for getElapsedTime($start), doc says int $start but if you look at how it's actually used, it's passing a float (see below).

framework/src/Illuminate/Database/Connection.php

Lines 789 to 791 in 5c9cb78

$this->logQuery(
$query, $bindings, $this->getElapsedTime($start)
);

@taka-oyama taka-oyama changed the title [11.x] fix PHPDoc for \Illuminate\Database\Connection properties. [11.x] fix PHPDoc for \Illuminate\Database\Connection properties Oct 18, 2024
@taka-oyama taka-oyama changed the title [11.x] fix PHPDoc for \Illuminate\Database\Connection properties [11.x] fix PHPDoc for \Illuminate\Database\Connection Oct 18, 2024
@taylorotwell taylorotwell merged commit 4b0e358 into laravel:11.x Oct 18, 2024
31 checks passed
@taka-oyama taka-oyama deleted the fix/db-connection-doc branch October 18, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@taka-oyama @taylorotwell