[11.x] Improves PHP 8.4 compatibility #53182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Contributor
| @crynobone Is it correct that we all need to update al these method properties? Otherwise I will create a script to update them in batches. Where we use like:
|
Member Author
| That's doesn't require any changes. Please read what's new on PHP 8.4 for further detail |
| php: | ||
| preset: laravel | ||
| version: 8.2 | ||
| enabled: |
Collaborator
There was a problem hiding this comment.
I could update the Laravel preset to include this, instead, if you'd prefer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Notice this while adding PHP 8.4 support to
laravel/pail