[11.x] Auto discover Events outside app namespace when folder name is in kebab-case #52976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xizprodev force-pushed the 11.x_52975_discover_events branch from 3133bb5 to b6c8e15 Compare 
Member
| @xizprodev Please update the title and description for this PR so @taylorotwell can understand this better without having to read both PR and issue. |
xizprodev changed the title 
Contributor Author
| @crynobone updated! |
crynobone changed the title crynobone changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Should fix:
#52975
Reproduction repo url: https://github.com/xizprodev/laravel-with-events.
Update:
Laravel 11 events are not auto discovered outside app folder when folder name is in kebab-case.
Example structure:
app
bootstrap
...
modules
modules-core (like custom-namespace in repo example)
In this case The method
DiscoverEvents::classFromFilereturnCustom-namespace\FolderName\Listeners\CustomListenerNameinstead ofCustomNamespace\FolderName\Listeners\CustomListenerName