Skip to content

[11.x] Document callable types for Enumerable::implode() #52937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

[11.x] Document callable types for Enumerable::implode() #52937

merged 1 commit into from
Sep 27, 2024

Conversation

@devfrey
Copy link
Contributor

@devfrey devfrey commented Sep 26, 2024 •
edited
Loading

I ran into an issue where PHPStan didn't check if the callable parameters for implode() matched the types of my collection. I've documented the callable types for Collection::implode() and LazyCollection::implode(). These methods forward the callable to map(), which is documented as callable(TValue, TKey): TMapValue.
@taylorotwell taylorotwell merged commit 28ff0e3 into laravel:11.x Sep 27, 2024
32 checks passed
@devfrey devfrey deleted the generic-implode branch September 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@devfrey @taylorotwell