[11.x] Fix for not automatically registering commands in App\Console\Commands #52903
+7 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks! Was about to send the same PR, just ended running the local tests =) |
Contributor
| @taylorotwell Could you please take a look into this? We need this as soon as possible. Without it, no custom commands can be executed, making it impossible to use the latest version. |
Member
| @SamuelNitsche this PR has been reverted due to breaking change with existing application. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR #52867 introduced a Bug #52902 when registering commands using both the
routes/console.phpandapp/Commandsnamespace.This PR fixes the bug by simply merging the commands found.
Again, unfortunately no tests.