Skip to content

[11.x] Suggest laravel/serializable-closure on Database component #52835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

[11.x] Suggest laravel/serializable-closure on Database component #52835

merged 1 commit into from
Sep 18, 2024

Conversation

@crynobone
Copy link
Member

@crynobone crynobone commented Sep 18, 2024

No description provided.

@crynobone
[11.x] Suggest laravel/serializable-closure on Database component
9d3ba3b 
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review September 18, 2024 00:13
@taylorotwell taylorotwell merged commit b4d9257 into 11.x Sep 18, 2024
@taylorotwell taylorotwell deleted the suggest-for-database branch September 18, 2024 14:22
@parallels999
Copy link

parallels999 commented Oct 31, 2024

@crynobone hi, why just suggest??

A third party package only uses "illuminate/database": ">=5.6 <12.0", but 11.x doesn't has laravel/serializable-closure as requirement, but it seems that it is being used on 11.x

Message was: "Class "Laravel\SerializableClosure\Support\ReflectionClosure" not found" at vendor\illuminate\support\Onceable.php:66 vendor\illuminate\support\Onceable.php:34 vendor\illuminate\database\Eloquent\Concerns\PreventsCircularRecursion.php:29 vendor\illuminate\database\Eloquent\Concerns\HasRelationships.php:795 vendor\illuminate\database\Eloquent\Model.php:1204 vendor\illuminate\database\Eloquent\Model.php:1174 tests\Unit\HasManyTest.php:401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@crynobone @parallels999 @taylorotwell