[11.x] Fix etag headers for binary file responses #52705
Merged
+10 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wouterrutgers changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
getContentmethod always returnsfalsefor instances ofBinaryFileResponseorStreamedResponse. Consequently, for any file served viareturn response()->download(...), the ETag header wil be set to the MD5 hash offalse, which isd41d8cd98f00b204e9800998ecf8427e.This leads to an identical ETag for all downloads, regardless of the actual file content. I propose that the ETag header be removed in cases where the content cannot be determined, as this would provide a more accurate response.