[10.x] Fix PHP_CLI_SERVER_WORKERS warning by suppressing it #52094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pelomedusa changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Context :
When using the PHP_CLI_SERVER_WORKERS environment variable with anything but 1, the command
php artisan serveshows a warning with each HTTP request, sometimes multiple time depending on the value:[Thu Jul 11 19:22:57 2024] Failed to poll event.This PR remove this warning by applying the same fix as on 11.x (see #50821 )
Steps to reproduce :
Additional infos :
Before v10.40.0, the warning exists but does not show any message, just the date:
[Thu Jul 11 19:01:20 2024]The warning come from PHP itself but i did not go as far as compiling PHP myself to investigate further.
I assumed if the same fix was merged in 11.x, this PR was enough
This is my first PR on this repository, if you requires anything else please let me know.