[11.x] Improve Schema::hasTable() performance (#53006)

* improve has table performance * fix tests * fix tests * fix tests

Author: hafezdivandari

src/Illuminate/Database/Schema/Builder.php

@@ -144,8 +144,7 @@ public function hasTable($table)
  {
  $table = $this->connection->getTablePrefix().$table;
 
- /** @phpstan-ignore arguments.count (SQLite accepts a withSize argument) */
- foreach ($this->getTables(false) as $value) {
+ foreach ($this->getTables() as $value) {
  if (strtolower($table) === strtolower($value['name'])) {
  return true;
  }

src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php

@@ -76,6 +76,23 @@ public function compileDropDatabaseIfExists($name)
  );
  }
 
+ /**
+ * Compile the query to determine if the given table exists.
+ *
+ * @param string $database
+ * @param string $table
+ * @return string
+ */
+ public function compileTableExists($database, $table)
+ {
+ return sprintf(
+ 'select exists (select 1 from information_schema.tables where '
+ ."table_schema = %s and table_name = %s and table_type in ('BASE TABLE', 'SYSTEM VERSIONED')) as `exists`",
+ $this->quoteString($database),
+ $this->quoteString($table)
+ );
+ }
+
  /**
  * Compile the query to determine the tables.
  *

src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php

@@ -68,6 +68,23 @@ public function compileDropDatabaseIfExists($name)
  );
  }
 
+ /**
+ * Compile the query to determine if the given table exists.
+ *
+ * @param string $schema
+ * @param string $table
+ * @return string
+ */
+ public function compileTableExists($schema, $table)
+ {
+ return sprintf(
+ 'select exists (select 1 from pg_class c, pg_namespace n where '
+ ."n.nspname = %s and c.relname = %s and c.relkind in ('r', 'p') and n.oid = c.relnamespace)",
+ $this->quoteString($schema),
+ $this->quoteString($table)
+ );
+ }
+
  /**
  * Compile the query to determine the tables.
  *

src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php

@@ -68,6 +68,20 @@ public function compileDbstatExists()
  return "select exists (select 1 from pragma_compile_options where compile_options = 'ENABLE_DBSTAT_VTAB') as enabled";
  }
 
+ /**
+ * Compile the query to determine if the given table exists.
+ *
+ * @param string $table
+ * @return string
+ */
+ public function compileTableExists($table)
+ {
+ return sprintf(
+ 'select exists (select 1 from sqlite_master where name = %s and type = \'table\') as "exists"',
+ $this->quoteString(str_replace('.', '__', $table))
+ );
+ }
+
  /**
  * Compile the query to determine the tables.
  *

src/Illuminate/Database/Schema/Grammars/SqlServerGrammar.php

@@ -76,6 +76,21 @@ public function compileDropDatabaseIfExists($name)
  );
  }
 
+ /**
+ * Compile the query to determine if the given table exists.
+ *
+ * @param string|null $schema
+ * @param string $table
+ * @return string
+ */
+ public function compileTableExists($schema, $table)
+ {
+ return sprintf(
+ 'select (case when object_id(%s, \'U\') is null then 0 else 1 end) as [exists]',
+ $this->quoteString($schema ? $schema.'.'.$table : $table)
+ );
+ }
+
  /**
  * Compile the query to determine the tables.
  *

src/Illuminate/Database/Schema/MySqlBuilder.php

@@ -30,6 +30,23 @@ public function dropDatabaseIfExists($name)
  );
  }
 
+ /**
+ * Determine if the given table exists.
+ *
+ * @param string $table
+ * @return bool
+ */
+ public function hasTable($table)
+ {
+ $table = $this->connection->getTablePrefix().$table;
+
+ $database = $this->connection->getDatabaseName();
+
+ return (bool) $this->connection->scalar(
+ $this->grammar->compileTableExists($database, $table)
+ );
+ }
+
  /**
  * Get the tables for the database.
  *

src/Illuminate/Database/Schema/PostgresBuilder.php

@@ -49,14 +49,9 @@ public function hasTable($table)
 
  $table = $this->connection->getTablePrefix().$table;
 
- foreach ($this->getTables() as $value) {
- if (strtolower($table) === strtolower($value['name'])
- && strtolower($schema) === strtolower($value['schema'])) {
- return true;
- }
- }
-
- return false;
+ return (bool) $this->connection->scalar(
+ $this->grammar->compileTableExists($schema, $table)
+ );
  }
 
  /**

src/Illuminate/Database/Schema/SQLiteBuilder.php

@@ -31,6 +31,21 @@ public function dropDatabaseIfExists($name)
  : true;
  }
 
+ /**
+ * Determine if the given table exists.
+ *
+ * @param string $table
+ * @return bool
+ */
+ public function hasTable($table)
+ {
+ $table = $this->connection->getTablePrefix().$table;
+
+ return (bool) $this->connection->scalar(
+ $this->grammar->compileTableExists($table)
+ );
+ }
+
  /**
  * Get the tables for the database.
  *

src/Illuminate/Database/Schema/SqlServerBuilder.php

@@ -42,17 +42,11 @@ public function hasTable($table)
  {
  [$schema, $table] = $this->parseSchemaAndTable($table);
 
- $schema ??= $this->getDefaultSchema();
  $table = $this->connection->getTablePrefix().$table;
 
- foreach ($this->getTables() as $value) {
- if (strtolower($table) === strtolower($value['name'])
- && strtolower($schema) === strtolower($value['schema'])) {
- return true;
- }
- }
-
- return false;
+ return (bool) $this->connection->scalar(
+ $this->grammar->compileTableExists($schema, $table)
+ );
  }
 
  /**

tests/Database/DatabaseMariaDbSchemaBuilderTest.php

@@ -20,15 +20,12 @@ public function testHasTable()
  {
  $connection = m::mock(Connection::class);
  $grammar = m::mock(MariaDbGrammar::class);
- $processor = m::mock(MariaDbProcessor::class);
  $connection->shouldReceive('getDatabaseName')->andReturn('db');
  $connection->shouldReceive('getSchemaGrammar')->andReturn($grammar);
- $connection->shouldReceive('getPostProcessor')->andReturn($processor);
  $builder = new MariaDbBuilder($connection);
- $grammar->shouldReceive('compileTables')->once()->andReturn('sql');
- $processor->shouldReceive('processTables')->once()->andReturn([['name' => 'prefix_table']]);
+ $grammar->shouldReceive('compileTableExists')->once()->andReturn('sql');
  $connection->shouldReceive('getTablePrefix')->once()->andReturn('prefix_');
- $connection->shouldReceive('selectFromWriteConnection')->once()->with('sql')->andReturn([['name' => 'prefix_table']]);
+ $connection->shouldReceive('scalar')->once()->with('sql')->andReturn(1);
 
  $this->assertTrue($builder->hasTable('table'));
  }