only forget when parent key is forgotten

Author: timacdonald

src/Illuminate/Cache/FileStore.php

@@ -247,12 +247,13 @@ public function restoreLock($name, $owner)
  */
  public function forget($key)
  {
- if ($this->files->exists($file = $this->path("illuminate:cache:flexible:created:{$key}"))) {
- $this->files->delete($file);
- }
 
  if ($this->files->exists($file = $this->path($key))) {
- return $this->files->delete($file);
+ return tap($this->files->delete($file), function ($forgotten) use ($key) {
+ if ($forgotten && $this->files->exists($file = $this->path("illuminate:cache:flexible:created:{$key}"))) {
+ $this->files->delete($file);
+ }
+ });
  }
 
  return false;

tests/Cache/CacheFileStoreTest.php

@@ -350,6 +350,30 @@ public function testItHandlesForgettingNonFlexibleKeys()
  $this->assertFileDoesNotExist($flexiblePath);
  }
 
+ public function itOnlyForgetsFlexibleKeysIfParentIsForgotten()
+ {
+ $store = new FileStore(new Filesystem, __DIR__);
+
+ $key = Str::random();
+ $path = $store->path($key);
+ $flexiblePath = "illuminate:cache:flexible:created:{$key}";
+
+ touch($flexiblePath);
+
+ $this->assertFileDoesNotExist($path);
+ $this->assertFileExists($flexiblePath);
+
+ $store->forget($key);
+
+ $this->assertFileDoesNotExist($path);
+ $this->assertFileExists($flexiblePath);
+
+ $store->put($key, 'value', 5);
+
+ $this->assertFileDoesNotExist($path);
+ $this->assertFileDoesNotExist($flexiblePath);
+ }
+
  protected function mockFilesystem()
  {
  return $this->createMock(Filesystem::class);