Ensure headers are only attached to illuminate responses (#52789)

Author: timacdonald

src/Illuminate/Http/Middleware/AddLinkHeadersForPreloadedAssets.php

@@ -2,6 +2,7 @@
 
 namespace Illuminate\Http\Middleware;
 
+use Illuminate\Http\Response;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Vite;
 
@@ -17,7 +18,7 @@ class AddLinkHeadersForPreloadedAssets
  public function handle($request, $next)
  {
  return tap($next($request), function ($response) {
- if (Vite::preloadedAssets() !== []) {
+ if ($response instanceof Response && Vite::preloadedAssets() !== []) {
  $response->header('Link', Collection::make(Vite::preloadedAssets())
  ->map(fn ($attributes, $url) => "<{$url}>; ".implode('; ', $attributes))
  ->join(', '));

tests/Http/Middleware/VitePreloadingTest.php

@@ -9,6 +9,7 @@
 use Illuminate\Http\Response;
 use Illuminate\Support\Facades\Facade;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\HttpFoundation\Response as SymfonyResponse;
 
 class VitePreloadingTest extends TestCase
 {
@@ -20,7 +21,7 @@ protected function tearDown(): void
 
  public function testItDoesNotSetLinkTagWhenNoTagsHaveBeenPreloaded()
  {
- $app = new Container();
+ $app = new Container;
  $app->instance(Vite::class, new class extends Vite
  {
  protected $preloadedAssets = [];
@@ -36,7 +37,7 @@ public function testItDoesNotSetLinkTagWhenNoTagsHaveBeenPreloaded()
 
  public function testItAddsPreloadLinkHeader()
  {
- $app = new Container();
+ $app = new Container;
  $app->instance(Vite::class, new class extends Vite
  {
  protected $preloadedAssets = [
@@ -57,4 +58,25 @@ public function testItAddsPreloadLinkHeader()
  '<https://laravel.com/app.js>; rel="modulepreload"; foo="bar"'
  );
  }
+
+ public function testItDoesNotAttachHeadersToNonIlluminateResponses()
+ {
+ $app = new Container;
+ $app->instance(Vite::class, new class extends Vite
+ {
+ protected $preloadedAssets = [
+ 'https://laravel.com/app.js' => [
+ 'rel="modulepreload"',
+ 'foo="bar"',
+ ],
+ ];
+ });
+ Facade::setFacadeApplication($app);
+
+ $response = (new AddLinkHeadersForPreloadedAssets)->handle(new Request, function () {
+ return new SymfonyResponse('Hello Laravel');
+ });
+
+ $this->assertNull($response->headers->get('Link'));
+ }
 }