Skip to content

Commit 4bef9bd

Browse files
committed
make update-lint
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
1 parent cf9c624 commit 4bef9bd

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

pkg/apiserver/endpoints/handlers/get.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,5 +181,5 @@ func getRequestOptions(req *http.Request, scope handlers.RequestScope, into runt
181181
newQuery[subpathKey] = []string{p}
182182
query = newQuery
183183
}
184-
return scope.ParameterCodec.DecodeParameters(query, scope.Kind.GroupVersion(), into)
184+
return scope.DecodeParameters(query, scope.Kind.GroupVersion(), into)
185185
}

pkg/cmd/builder.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func (b *AdapterBase) InstallFlags() {
109109
b.CustomMetricsAdapterServerOptions = options.NewCustomMetricsAdapterServerOptions()
110110
}
111111

112-
b.CustomMetricsAdapterServerOptions.AddFlags(b.FlagSet)
112+
b.AddFlags(b.FlagSet)
113113

114114
b.FlagSet.StringVar(&b.RemoteKubeConfigFile, "lister-kubeconfig", b.RemoteKubeConfigFile,
115115
"kubeconfig file pointing at the 'core' kubernetes server with enough rights to list "+
@@ -294,7 +294,7 @@ func (b *AdapterBase) Config() (*apiserver.Config, error) {
294294
}
295295
b.CustomMetricsAdapterServerOptions.OpenAPIV3Config = b.OpenAPIV3Config
296296

297-
if errList := b.CustomMetricsAdapterServerOptions.Validate(); len(errList) > 0 {
297+
if errList := b.Validate(); len(errList) > 0 {
298298
return nil, utilerrors.NewAggregate(errList)
299299
}
300300

@@ -307,7 +307,7 @@ func (b *AdapterBase) Config() (*apiserver.Config, error) {
307307
serverConfig := genericapiserver.NewRecommendedConfig(apiserver.Codecs)
308308
serverConfig.ClientConfig = b.clientConfig
309309
serverConfig.SharedInformerFactory = b.informers
310-
err = b.CustomMetricsAdapterServerOptions.ApplyTo(serverConfig)
310+
err = b.ApplyTo(serverConfig)
311311
if err != nil {
312312
return nil, err
313313
}

test-adapter/provider/provider.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,8 @@ func (p *testingProvider) updateMetric(request *restful.Request, response *restf
157157

158158
namespace := request.PathParameter("namespace")
159159
resourceType := request.PathParameter("resourceType")
160-
namespaced := false
161-
if len(namespace) > 0 || resourceType == "namespaces" {
162-
namespaced = true
163-
}
160+
namespaced := len(namespace) > 0 || resourceType == "namespaces"
161+
164162
name := request.PathParameter("name")
165163
metricName := request.PathParameter("metric")
166164

0 commit comments

Comments
 (0)