🌱 Add JoelSpeed to reviewers #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added the cncf-cla: yes k8s-ci-robot added the size/XS 
camilamacedo86 approved these changes Jan 29, 2025
k8s-ci-robot added the lgtm 
Contributor
| LGTM label has been added. Git tree hash: 7ce1cbcc34dc60408d2933f360366a38af655666 |
Member
| /lgtm Thank you very much for volunteering, really apprecate it! |
Member
| /assign @alvaroaleman @vincepri |
alvaroaleman approved these changes Jan 29, 2025
Member
alvaroaleman left a comment
alvaroaleman left a comment There was a problem hiding this comment.
Yep, lets formalize what is effectively the reality already :)
Contributor
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, camilamacedo86, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved 
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've been following this repo, commenting on issues, reviewing various PRs and contributing bug fixes for a long time.
I have expertise around the Kube API space and in particular around the tooling for CRD generation that lives within this repository.
Figured it might be helpful to offer some review time to help alleviate some of the pressure on current maintainers.