✨ Leverage isInInitialList of ResourceEventHandler.OnAdd, Add IsInInitialList to TypedCreateEvent #3162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added do-not-merge/work-in-progress k8s-ci-robot added approved 
sbueringer force-pushed the pr-initial-list branch 2 times, most recently from c423650 to 8b4eacb Compare 
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer force-pushed the pr-initial-list branch from 8b4eacb to f4ad346 Compare 
| cc @howardjohn (as this is basically a follow-up to #2223) |
| /assign @alvaroaleman @vincepri |
sbueringer changed the title k8s-ci-robot removed the do-not-merge/work-in-progress sbueringer changed the title sbueringer changed the title 
alvaroaleman approved these changes Mar 16, 2025
k8s-ci-robot added the lgtm 
| LGTM label has been added. Git tree hash: 7e93121436ab7aaecc13f3a2a185bfe6f1cc5b62 |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| /hold cancel |
k8s-ci-robot removed the do-not-merge/hold | Thx again @caozhuozi for bringing this one up! :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
Let's start using IsInitialList that is provided in the OnAdd func of ResourceEventHandlers.
This can be leveraged to determine in a clean way if an add/create event came from an initial list.
https://kubernetes.slack.com/archives/C02MRBMN00Z/p1742119089612549?thread_ts=1741482643.357719&cid=C02MRBMN00Z
Reverts the parts of #2223 that we don't need anymore.