✨ MD: Implement CanUpdateMachineSet #12965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added cncf-cla: yes 
sbueringer changed the title k8s-ci-robot added the size/XXL k8s-ci-robot added the do-not-merge/work-in-progress 80 tasks
sbueringer added the area/machinedeployment sbueringer force-pushed the pr-can-update-machineset branch 2 times, most recently from 5896543 to 7c325f8 Compare k8s-ci-robot added size/XL sbueringer force-pushed the pr-can-update-machineset branch 5 times, most recently from 4178ca8 to 6813157 Compare 
Member Author
| /test pull-cluster-api-e2e-main-gke |
sbueringer force-pushed the pr-can-update-machineset branch from 6813157 to 3c99995 Compare k8s-ci-robot added size/XXL 
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer force-pushed the pr-can-update-machineset branch from 3c99995 to d02f2b2 Compare Member Author
| /test pull-cluster-api-e2e-main-gke |
sbueringer changed the title k8s-ci-robot removed the do-not-merge/work-in-progress Member Author
| /test pull-cluster-api-e2e-main-gke |
sbueringer commented Nov 7, 2025
internal/controllers/machinedeployment/machinedeployment_canupdatemachineset.go Outdated Show resolved Hide resolved
Member Author
| /test pull-cluster-api-e2e-main-gke |
sbueringer added the tide/merge-method-squash 
Member
fabriziopandini left a comment
fabriziopandini left a comment There was a problem hiding this comment.
Thanks for the efforts in keeping consistent CanUpdateMachineSet and CanUpdateMachine, this really made the difference while reviewing this PR
internal/controllers/machinedeployment/machinedeployment_canupdatemachineset.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/machinedeployment_canupdatemachineset.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/machinedeployment_canupdatemachineset_test.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/machinedeployment_canupdatemachineset_test.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/machinedeployment_canupdatemachineset_test.go Outdated Show resolved Hide resolved
Member Author
| /test pull-cluster-api-e2e-main-gke |
Member Author
| @fabriziopandini PTAL :) |
sbueringer force-pushed the pr-can-update-machineset branch from 944b0c2 to ab5a46e Compare Member Author
| /test pull-cluster-api-e2e-main-gke |
Member
| /lgtm |
k8s-ci-robot added the lgtm 
Contributor
| LGTM label has been added. DetailsGit tree hash: fa903b9ab0bd509842bbd77eacd22bfd8b53b9c1 |
Contributor
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #12291