Skip to content

🌱 Add items to cache immediately after apply #12877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Nov 2, 2025
Merged

🌱 Add items to cache immediately after apply #12877

k8s-ci-robot merged 2 commits into from
Nov 2, 2025
+104 −33

Conversation

@lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Oct 20, 2025

What this PR does / why we need it:

Add items to cache immediately after apply to avoid extra no-op patch just for caching.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #12291
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2025
@lentzi90 lentzi90 force-pushed the lentzi90/ssa-cache-after-apply branch from 5e9c698 to 83a129c Compare October 23, 2025 07:21
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2025
@lentzi90 lentzi90 force-pushed the lentzi90/ssa-cache-after-apply branch from 83a129c to 3f0d275 Compare October 23, 2025 07:24
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@lentzi90 lentzi90 changed the title 🌱 WIP: Add items to cache immediately after apply 🌱 Add items to cache immediately after apply Oct 23, 2025
@sbueringer sbueringer added the area/util Issues or PRs related to utils label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 23, 2025
sbueringer
sbueringer reviewed Oct 23, 2025
View reviewed changes
@lentzi90 lentzi90 force-pushed the lentzi90/ssa-cache-after-apply branch 2 times, most recently from 2355648 to f8f74c5 Compare October 28, 2025 13:50
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2025
lentzi90
lentzi90 commented Oct 28, 2025
View reviewed changes
@lentzi90 lentzi90 force-pushed the lentzi90/ssa-cache-after-apply branch from f8f74c5 to 6b2932e Compare October 29, 2025 07:43
@lentzi90
Add items to cache immediately after apply
2634ca3 
This improves the SSA helper by avoding a second no-op patch just to add items to the cache. Instead we calculate the new request identifier and add to the cache directly. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/ssa-cache-after-apply branch from 6b2932e to c0c8c9a Compare October 29, 2025 07:54
@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 29, 2025

Hmm race detected. I wonder if that could be a genuine issue from the code change 🤔
/test pull-cluster-api-test-main
@sbueringer
Copy link
Member

sbueringer commented Oct 30, 2025

Should be unrelated to your PR . I'll take a closer look during review. Also very likely the race is just in test code (fake client)
sbueringer
sbueringer reviewed Oct 30, 2025
View reviewed changes
@sbueringer
Copy link
Member

sbueringer commented Oct 30, 2025

@lentzi90 Thank you very much. Last nit. I also tested it with Tilt and it works perfectly
@sbueringer sbueringer mentioned this pull request Oct 30, 2025
Open
80 tasks
@lentzi90
Change ComputeRequestIdentifier parameters to clarify usage
5d3943e 
Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/ssa-cache-after-apply branch from c0c8c9a to 5d3943e Compare October 31, 2025 07:03
@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 31, 2025

Thanks! Fixed the last nit. Do you want me to squash the commits? I kept the changes to ComputeRequestIdentifier on a separate commit for now since I wasn't sure if we wanted it.
@sbueringer
Copy link
Member

sbueringer commented Oct 31, 2025

Separate commits is fine.

Thank you!

/lgtm
/assign @fabriziopandini
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 31, 2025

LGTM label has been added.

DetailsGit tree hash: 44b6fc3887fa81c6adc276abef888b2632edac3b
@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 2, 2025

Thanks for this improvement (and thanks @sbueringer for helping in getting this PR is such a good state)!
/lgtm
/approve
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 313199c into kubernetes-sigs:main Nov 2, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 2, 2025
@lentzi90 lentzi90 deleted the lentzi90/ssa-cache-after-apply branch November 3, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

5 participants

@lentzi90 @sbueringer @k8s-ci-robot @fabriziopandini @furkatgofurov7