✨ Add in-place updates support for machine controller #12831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Skipping CI for Draft Pull Request. |
k8s-ci-robot added do-not-merge/work-in-progress k8s-ci-robot added the size/L 
sbueringer added the area/machine 80 tasks
alexander-demicev force-pushed the machinecontroller branch from 7bb3062 to b5b0b04 Compare 
sbueringer reviewed Oct 13, 2025
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
alexander-demicev force-pushed the machinecontroller branch 2 times, most recently from a88faa8 to ed1835e Compare sbueringer reviewed Oct 20, 2025
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
sbueringer reviewed Oct 20, 2025
alexander-demicev force-pushed the machinecontroller branch from ed1835e to 9bd69f3 Compare 
Contributor Author
| @sbueringer all comments addressed |
Member
| I think you can go ahead and add unit test coverage |
sbueringer reviewed Oct 24, 2025
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
alexander-demicev force-pushed the machinecontroller branch from 9bd69f3 to a6103fb Compare k8s-ci-robot removed the size/L k8s-ci-robot added size/XL alexander-demicev force-pushed the machinecontroller branch from a6103fb to 0d96713 Compare sbueringer reviewed Oct 30, 2025
internal/controllers/machine/machine_controller_inplace_update_test.go Outdated Show resolved Hide resolved
alexander-demicev force-pushed the machinecontroller branch from 0d96713 to f1ba5fd Compare sbueringer reviewed Oct 31, 2025
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
alexander-demicev force-pushed the machinecontroller branch 2 times, most recently from 1cc7470 to b6fd638 Compare 
alexander-demicev force-pushed the machinecontroller branch from b6fd638 to b66c3f6 Compare Member
furkatgofurov7 left a comment
furkatgofurov7 left a comment There was a problem hiding this comment.
Looks good to me, thanks for the PR
/lgtm
k8s-ci-robot added the lgtm Contributor
| LGTM label has been added. DetailsGit tree hash: 472d13609eb29aea21b9cb3de7ffed902b29d169 |
alexander-demicev force-pushed the machinecontroller branch 2 times, most recently from fb62c55 to 06e2193 Compare k8s-ci-robot removed the lgtm 
Member
fabriziopandini left a comment
fabriziopandini left a comment There was a problem hiding this comment.
Just a few nits from my side + one question
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go Outdated Show resolved Hide resolved
alexander-demicev force-pushed the machinecontroller branch from 06e2193 to 3cff7fc Compare 
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev force-pushed the machinecontroller branch from 3cff7fc to c315bcf Compare Member
| /lgtm |
k8s-ci-robot added the lgtm Contributor
| LGTM label has been added. DetailsGit tree hash: 701505f13ae97ef73a923f58216df4ba4baaff0b |
Member
| /test pull-cluster-api-e2e-main |
Member
| /approve |
Contributor
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of #12291
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #