Skip to content

✨ Additional validation in Cluster/ClusterClass webhook for chained upgrades #12816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Oct 9, 2025
Merged

✨ Additional validation in Cluster/ClusterClass webhook for chained upgrades #12816

k8s-ci-robot merged 2 commits into from
Oct 9, 2025

Conversation

@Karthik-K-N
Copy link
Contributor

@Karthik-K-N Karthik-K-N commented Oct 1, 2025

What this PR does / why we need it:
This PR will contain series of commits to add additional validation for Cluster/ClusterClass webhook for chained upgrades and associated UTs.

More info: #12720 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12720

/area clusterclass
@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2025
@Karthik-K-N
Copy link
Contributor Author

Karthik-K-N commented Oct 1, 2025

Apologies for delay, back from small vacation, will add other pending changes for clusterclass webhook and UT in following commits.
@sbueringer
Copy link
Member

sbueringer commented Oct 2, 2025

No problem! Welcome back and thx for working on this!
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2025
@Karthik-K-N
Copy link
Contributor Author

Karthik-K-N commented Oct 2, 2025

Added UT for cluster webhook
Added validation for ClusterClass update scenario.
Only thing pending is ClusterClass create case, will take that up if this approach looks good,

PR is ready for initial review.
Karthik-K-N
Karthik-K-N commented Oct 2, 2025
View reviewed changes
@sbueringer
Copy link
Member

sbueringer commented Oct 9, 2025

Thank you very much!!

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 9, 2025

LGTM label has been added.

DetailsGit tree hash: d7213032993ebe52e886d09fdce79272217bfb25
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3e31856 into kubernetes-sigs:main Oct 9, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

3 participants

@Karthik-K-N @sbueringer @k8s-ci-robot