[Fixes browsermedia#657] Can no longer delete homepage.

* The page with / (i.e. home) can no longer be deleted. * Add rake test_single gem to make it faster to run single test classes.

Author: peakpg

Gemfile

@@ -32,6 +32,7 @@ group :test do
  gem 'poltergeist'
  gem 'm', '~> 1.2'
 
+ gem 'single_test'
  gem 'factory_girl_rails', '3.3.0'
  gem "mocha", :require=>false
  gem "sqlite3-ruby", :require => "sqlite3"

Gemfile.lock

@@ -208,6 +208,8 @@ GEM
  simple_form (3.0.1)
  actionpack (>= 4.0.0, < 4.1)
  activemodel (>= 4.0.0, < 4.1)
+ single_test (0.6.0)
+ rake
  sprockets (2.10.1)
  hike (~> 1.2)
  multi_json (~> 1.0)
@@ -270,6 +272,7 @@ DEPENDENCIES
  quiet_assets
  rake
  ruby-prof
+ single_test
  sqlite3-ruby
  thin
  uglifier

Rakefile

@@ -19,6 +19,7 @@ load 'rails/tasks/engine.rake'
 Bundler::GemHelper.install_tasks
 
 require 'rake/testtask'
+require 'single_test/tasks'
 
 Rake::TestTask.new('units') do |t|
  t.libs << 'lib'
@@ -80,7 +81,7 @@ end
 
 desc 'Runs all the tests, specs and scenarios.'
 task :test => ['project:ensure_db_exists', 'app:test:prepare'] do
- tests_to_run = ENV['TEST'] ? ["test:single"] : %w(test:units spec test:functionals features)
+ tests_to_run = %w(test:units spec test:functionals features)
  run_tests(tests_to_run)
 end
 

app/models/cms/page.rb

@@ -379,6 +379,12 @@ def home?
  path == "/"
  end
 
+
+ # @return [Boolean] true if this page can be deleted or not.
+ def deletable?
+ !home?
+ end
+
  # This will return the "top level section" for this page, which is the section directly
  # below the root (a.k.a My Site) that this page is in. If this page is in root,
  # then this will return root.

app/models/cms/section_node.rb

@@ -80,7 +80,11 @@ def link?
  end
 
  def deletable?
- !self.root? && (!section? || node.deletable?)
+ return false if self.root?
+ if node.respond_to?(:deletable?)
+ return node.deletable?
+ end
+ true
  end
 
  # @param [Section] section

test/unit/models/page_test.rb

@@ -158,6 +158,12 @@ def setup
 
  class PageTest < ActiveSupport::TestCase
 
+ test "#deletable?" do
+ @page = build(:page, path: "/")
+ assert @page.home?
+ refute @page.deletable?
+ end
+
  def test_creating_page_with_reserved_path
  @page = Cms::Page.new(:name => "FAIL", :path => "/cms")
  assert_not_valid @page

test/unit/models/sections_test.rb

@@ -146,6 +146,13 @@ def test_empty_section
  assert_decremented section_node_count, Cms::SectionNode.count
  end
 
+ test "Homepage should not be #deletable?" do
+ home = build(:page)
+ home.path = "/"
+
+ refute home.section_node.deletable?, "Should not be able to delete the homepage as this will cause problems for sites."
+ end
+
  def test_creating_page_with_reserved_path
  @section = Cms::Section.new(:name => "FAIL", :path => "/cms")
  assert_not_valid @section