Fix validation test for Java 21 #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
OpenJDK 21 EA b15 and b16 produce different class files for `RecordPatternsTarget.java` because of openjdk/jdk@138cdc9 Here is diff between outputs of `javap -v -p RecordPatternsTarget.class`: ```diff line 34: 57 line 35: 72 + line 34: 78 line 37: 92 ``` Bytecode instructions at offset 78 correspond to the following exception handler generated for the `case` at line 34: ``` 78: astore_1 79: new jacoco#24 // class java/lang/MatchException 82: dup 83: aload_1 84: invokevirtual jacoco#26 // Method java/lang/Throwable.toString:()Ljava/lang/String; 87: aload_1 88: invokespecial jacoco#30 // Method java/lang/MatchException."<init>":(Ljava/lang/String;Ljava/lang/Throwable;)V 91: athrow ```
| @marchof note that I updated |
marchof approved these changes Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
OpenJDK 21 EA b15 and b16 produce different class files for
RecordPatternsTarget.javabecause ofopenjdk/jdk@138cdc9
Here is diff between outputs of
javap -v -p RecordPatternsTarget.class:line 34: 57 line 35: 72 + line 34: 78 line 37: 92Bytecode instructions at offset 78 correspond to the following exception handler generated for the
caseat line 34: