Depend upon traitlets >5.13.0 #14353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In previous versions, traitlets.List does not inherit from typing.Generic which means it does not implement __class_getitem__ which means List[ast.NodeTransformer] raises at runtime.
krassowski requested changes Feb 22, 2024
Member
krassowski left a comment
krassowski left a comment There was a problem hiding this comment.
5.10 is too low, I believe it needs to be 5.13
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski changed the title Contributor Author
| You're welcome! Thanks for the amazing project. |
Member
| We can do that or |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In previous versions,
traitlets.Listdoes not inherit fromtyping.Genericwhich means it does not implement__class_getitem__which meansList[ast.NodeTransformer]raises at runtime.