Improve validation on workflow crons (no arg schema allowed) or tasks in workflows (no args allowed without defaults)

Author: mktrevor

hyrex/hyrex_registry.py

@@ -223,6 +223,13 @@ def decorator(func):
  config_phase=ConfigPhase.decorator, queue=queue, priority=priority
  )
 
+ # Validate that cron workflows don't require arguments
+ if cron and workflow_arg_schema:
+ raise ValueError(
+ f"Workflow '{workflow_name}' has cron scheduling but requires arguments. "
+ f"Cron-scheduled workflows must not have any required arguments."
+ )
+ 
  # Create and return a HyrexWorkflow instance
  workflow = HyrexWorkflow(
  name=workflow_name,

hyrex/workflow/workflow_builder.py

@@ -91,6 +91,17 @@ def __exit__(self, exc_type, exc_value, traceback) -> None:
 
  def get_or_create_node(self, task_wrapper: TaskWrapper) -> DagNode:
  if task_wrapper not in self.nodes:
+ # Validate that the task doesn't have required arguments
+ required_params = [
+ name for name, info in task_wrapper.param_info.items() 
+ if not info.has_default
+ ]
+ if required_params:
+ raise ValueError(
+ f"Task '{task_wrapper.task_identifier}' cannot be used in a workflow because it requires arguments: {required_params}. "
+ f"Tasks used in workflows must have no arguments or all arguments must have default values."
+ )
+ 
  self.nodes[task_wrapper] = DagNode(
  task_wrapper=task_wrapper, workflow_builder=self
  )