Add HSM kms implementation #2105
Merged
+107 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: gtebrean <99179176+gtebrean@users.noreply.github.com>
NickSneo reviewed Oct 2, 2024
Member
NickSneo left a comment
NickSneo left a comment There was a problem hiding this comment.
Do we need to add some test cases?
Signed-off-by: gtebrean <99179176+gtebrean@users.noreply.github.com>
Contributor Author
can't be executed as a tes because will need to provide an AWS env with the KMS in order to can execute it, I tested it locally |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
required
Where should the reviewer start?
required
Why is it needed?
required
Checklist