docs: added note on how to avoid the incorrectly floating label in a select with empty value but non-empty text #634
+58 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…select with empty value Signed-off-by: JL102 <jordanlees@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was originally planning on creating a fix for this, which was pretty clearly a bug to me,
but then I saw that SMUI has no control over this particular issue. If the selected value is "",
like in the case of a default, but the text is still non-empty, floatLabel() is called with
value false, and I see that's controlled by @material/select, not SMUI.