build(deps): update HAR library #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The HAR library as we use it here depends on implementation details. Instead of the `UnmarshalJSON` and `MarshalJSON` functions that are (no longer) defined in the library, we should use `encoding/json` directly and let it do the indirection instead.
Proximyst requested review from andresmgot, s4kh and xnyo and removed request for a team 
|
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The HAR library as we use it here depends on implementation details. Instead of the
UnmarshalJSONandMarshalJSONfunctions that are (no longer) defined in the library, we should useencoding/jsondirectly and let it do the indirection instead.I discovered this while testing the viability of updating all dependencies in Grafana.