Skip to content

Conversation

@chingor13
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2019
@@ -0,0 +1,2 @@
releaseType: java-yoshi
bumpMinorPreMajor: true No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline at end of file

env_vars: {
key: "JOB_TYPE"
value: "lint"
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

env_vars: {
key: "JOB_TYPE"
value: "lint"
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

env_vars: {
key: "JOB_TYPE"
value: "clirr"
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/java-storage/.kokoro/linkage-monitor.sh"
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/java-storage/.kokoro/release/snapshot.sh"
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

mvn nexus-staging:release -B \
-DperformRelease=true \
--settings=settings.xml
fi No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

"repo_short": "java-storage",
"distribution_name": "com.google.cloud:google-cloud-storage",
"api_id": "storage.googleapis.com"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

</modules>
</profile>
</profiles>
</project> No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

"path": "__pycache__/synth.cpython-36.pyc"
}
]
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@035ae2a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3 +/- ## ========================================= Coverage ? 63.29% Complexity ? 528 ========================================= Files ? 30 Lines ? 4719 Branches ? 450 ========================================= Hits ? 2987 Misses ? 1571 Partials ? 161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035ae2a...29fe0a4. Read the comment docs.

@chingor13 chingor13 requested a review from codyoss December 26, 2019 21:23
@chingor13
Copy link
Contributor Author

@athakor These are common templates and should be addressed globally. I opened googleapis/synthtool#357 to track

@chingor13 chingor13 merged commit 39ff6f6 into googleapis:master Dec 26, 2019
@chingor13 chingor13 deleted the releasable branch December 26, 2019 21:27
BenWhitehead added a commit that referenced this pull request May 2, 2022
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: wip: first stab at trying to corral all {to,from}Pb methods from model classes # This is the commit message #2: wip: refactor all access of ApiaryConversions to use their intermediary `codec` method # This is the commit message #2: wip: add clirr rule to allow removing accidental public hmacKeyMetadata#toPb # This is the commit message #2: wip: add enum ApiaryConversions#Codecs # This is the commit message #3: wip: fix lifecycle rule tests # This is the commit message #4: wip: fix blob metadata encoding # This is the commit message #5: wip: replace Blob#fromPb and Bucket#fromPb with BlobInfo#asBlob and BucketInfo#asBucket The old fromPb method were conflating creating an instance of an "Info" model with create an instance of an "Info" model and binding it together with a Storage instance. Now, an instance of Info model can be decoded (where/whenever) and then turned into a Blob/Bucket as necessary. # This is the commit message #6: tersify conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants