fix: shutdown built in metrics meter provider #3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s ...loud-spanner/src/main/java/com/google/cloud/spanner/BuiltInOpenTelemetryMetricsProvider.java Outdated Show resolved Hide resolved
product-auto-label bot added size: xs 
sakthivelmanii approved these changes Nov 29, 2024
surbhigarg92 added kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
gcf-merge-on-green bot removed the automerge This was referenced Nov 29, 2024
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Dec 4, 2024
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.81.2` -> `6.82.0` | | [org.flywaydb:flyway-gradle-plugin](https://flywaydb.org) ([source](https://github.com/flyway/flyway)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `11.0.0` -> `11.0.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.24` -> `2.29.27` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.24` -> `2.29.27` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.24` -> `2.29.27` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.24` -> `2.29.27` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.24` -> `2.29.27` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.24` -> `2.29.27` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.82.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6820-2024-12-04) ##### Features - Add option for retrying DML as PDML ([#​3480](googleapis/java-spanner#3480)) ([b545557](googleapis/java-spanner@b545557)) - Add the last statement option to ExecuteSqlRequest and ExecuteBatchDmlRequest ([76ab801](googleapis/java-spanner@76ab801)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.50.0 ([76ab801](googleapis/java-spanner@76ab801)) - Shutdown built in metrics meter provider ([#​3518](googleapis/java-spanner#3518)) ([c935e2e](googleapis/java-spanner@c935e2e)) - **spanner:** GetEdition() is returning null for Instance ([#​3496](googleapis/java-spanner#3496)) ([77cb585](googleapis/java-spanner@77cb585)) ##### Dependencies - Update dependency commons-io:commons-io to v2.18.0 ([#​3492](googleapis/java-spanner#3492)) ([5c8b3ad](googleapis/java-spanner@5c8b3ad)) ##### Documentation - Add Multi Region Encryption samples ([#​3524](googleapis/java-spanner#3524)) ([316f971](googleapis/java-spanner@316f971)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 20ef292c9bda52c160283aea5bcf8ed8c6a44e21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR calls Meter provider shutdown method when the client is shutdown to clean up the resources and export the remaining metrics data.