- Notifications
You must be signed in to change notification settings - Fork 99
feat: add keepalive feature to tear down streams in their absence #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| /gcbrun |
Contributor Author
| /gcbrun |
2 similar comments
Contributor Author
| /gcbrun |
Contributor
| /gcbrun |
Contributor Author
| /gcbrun |
Contributor Author
| /gcbrun |
1 similar comment
Contributor
| /gcbrun |
michaelpri10 requested changes Oct 31, 2025
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated Show resolved Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Show resolved Hide resolved
1d72626 to 4b4f2b3 Compare Contributor Author
| /gcbrun |
2 similar comments
Contributor Author
| /gcbrun |
Contributor
| /gcbrun |
michaelpri10 reviewed Nov 5, 2025
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated Show resolved Hide resolved
Contributor
| /gcbrun |
Contributor Author
| /gcbrun |
1 similar comment
Contributor
| /gcbrun |
Contributor Author
| /gcbrun |
2 similar comments
Contributor Author
| /gcbrun |
Contributor
| /gcbrun |
Contributor Author
| /gcbrun |
1 similar comment
Contributor
| /gcbrun |
michaelpri10 approved these changes Dec 1, 2025
abbrowne126 approved these changes Dec 1, 2025
This was referenced Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.