Skip to content

feat: Enable instream retry for default streams when Multiplexing. #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yirutang merged 2 commits into from
Jan 25, 2024
Merged

feat: Enable instream retry for default streams when Multiplexing. #2376

yirutang merged 2 commits into from
Jan 25, 2024

Conversation

@egreco12
Copy link
Contributor

@egreco12 egreco12 commented Jan 22, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@egreco12 egreco12 requested a review from a team as a code owner January 22, 2024 20:23
@egreco12 egreco12 requested a review from PhongChuong January 22, 2024 20:23
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Jan 22, 2024
agrawal-siddharth
agrawal-siddharth approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@agrawal-siddharth agrawal-siddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add additional unit and e2e tests once this is submitted. I have verified these locally.
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@yirutang yirutang merged commit 9a18523 into googleapis:main Jan 25, 2024
@release-please release-please bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.

3 participants

@egreco12 @yirutang @agrawal-siddharth