Skip to content

fix: Update experimental methods documentation to @internalapi #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: Update experimental methods documentation to @internalapi #3552

merged 2 commits into from
Oct 31, 2024

Conversation

@PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Oct 28, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Oct 28, 2024
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 28, 2024
@PhongChuong PhongChuong changed the title docs: Update experimental methods documentation to @internalapi fix: Update experimental methods documentation to @internalapi Oct 28, 2024
@PhongChuong PhongChuong marked this pull request as ready for review October 28, 2024 16:03
@PhongChuong PhongChuong requested a review from a team as a code owner October 28, 2024 16:03
whuffman36
whuffman36 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@PhongChuong PhongChuong merged commit 20826f1 into main Oct 31, 2024
17 checks passed
@PhongChuong PhongChuong deleted the b372522255 branch October 31, 2024 17:07
@release-please release-please bot mentioned this pull request Oct 30, 2024
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.

3 participants

@PhongChuong @shollyman @whuffman36