build(deps): bump docker/docker to v28.0.0+incompatible #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
And adjust for breaking API changes. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
jonjohnsonjr approved these changes Feb 25, 2025
luhring added a commit to wolfi-dev/wolfictl that referenced this pull request Feb 26, 2025
To pick up the fix to broken builds: google/go-containerregistry#2071 Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
luhring added a commit to wolfi-dev/wolfictl that referenced this pull request Feb 26, 2025
To pick up the fix to broken builds: google/go-containerregistry#2071 Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
| Excited to see this has been addressed! Is there a release planned soon that includes this? |
| @jonjohnsonjr @imjasonh @mattmoor Do you have any plans for a release? I'm using this module indirectly, but every time I update go.mod, I keep running into this error. |
| 🤷 FWIW, I'm also running into an issue that looks related to this PR via a Dependabot update that didn't touch
$ go build -mod=vendor ./cmd/scan # github.com/google/go-containerregistry/pkg/v1/daemon vendor/github.com/google/go-containerregistry/pkg/v1/daemon/options.go:40:9: cannot use client.NewClientWithOpts(client.FromEnv) (value of type *client.Client) as Client value in return statement: *client.Client does not implement Client (wrong type for method ImageHistory) have ImageHistory(context.Context, string, ...client.ImageHistoryOption) ([]image.HistoryResponseItem, error) want ImageHistory(context.Context, string) ([]image.HistoryResponseItem, error)098045d#diff-517aa68b1408ed1ee9038fed40728dd8333b78d49efba0e0a873ccb5c2301644 |
This was referenced May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
And adjust for breaking API changes.