Skip to content

Commit 4ae052e

Browse files
l46kokcopybara-github
authored andcommitted
Fix CEL-Java to be fully protobuf v4 compatible
Fixes #462 PiperOrigin-RevId: 684215593
1 parent 0da0145 commit 4ae052e

File tree

30 files changed

+72
-69
lines changed

30 files changed

+72
-69
lines changed

.bazelrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
build --cxxopt=-std=c++14
2+
build --host_cxxopt=-std=c++14
3+
common --noenable_bzlmod

WORKSPACE

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -73,20 +73,20 @@ maven_install(
7373
"com.google.auto.value:auto-value:1.11.0",
7474
"com.google.auto.value:auto-value-annotations:1.11.0",
7575
"com.google.code.findbugs:annotations:3.0.1",
76-
"com.google.errorprone:error_prone_annotations:2.30.0",
77-
"com.google.guava:guava:33.3.0-jre",
78-
"com.google.guava:guava-testlib:33.3.0-jre",
79-
"com.google.protobuf:protobuf-java:4.28.0",
80-
"com.google.protobuf:protobuf-java-util:4.28.0",
76+
"com.google.errorprone:error_prone_annotations:2.33.0",
77+
"com.google.guava:guava:33.3.1-jre",
78+
"com.google.guava:guava-testlib:33.3.1-jre",
79+
"com.google.protobuf:protobuf-java:4.28.2",
80+
"com.google.protobuf:protobuf-java-util:4.28.2",
8181
"com.google.re2j:re2j:1.7",
82-
"com.google.testparameterinjector:test-parameter-injector:1.15",
83-
"com.google.truth.extensions:truth-java8-extension:1.4.2",
84-
"com.google.truth.extensions:truth-proto-extension:1.4.2",
85-
"com.google.truth:truth:1.4.2",
82+
"com.google.testparameterinjector:test-parameter-injector:1.18",
83+
"com.google.truth.extensions:truth-java8-extension:1.4.4",
84+
"com.google.truth.extensions:truth-proto-extension:1.4.4",
85+
"com.google.truth:truth:1.4.4",
8686
"org.antlr:antlr4-runtime:" + ANTLR4_VERSION,
8787
"org.jspecify:jspecify:1.0.0",
8888
"org.threeten:threeten-extra:1.8.0",
89-
"org.yaml:snakeyaml:2.2",
89+
"org.yaml:snakeyaml:2.3",
9090
],
9191
repositories = [
9292
"https://maven.google.com",
@@ -96,9 +96,9 @@ maven_install(
9696

9797
http_archive(
9898
name = "com_google_protobuf",
99-
sha256 = "13e7749c30bc24af6ee93e092422f9dc08491c7097efa69461f88eb5f61805ce",
100-
strip_prefix = "protobuf-28.0",
101-
urls = ["https://github.com/protocolbuffers/protobuf/archive/v28.0.tar.gz"],
99+
sha256 = "b2340aa47faf7ef10a0328190319d3f3bee1b24f426d4ce8f4253b6f27ce16db",
100+
strip_prefix = "protobuf-28.2",
101+
urls = ["https://github.com/protocolbuffers/protobuf/archive/v28.2.tar.gz"],
102102
)
103103

104104
# Required by com_google_protobuf

bundle/src/main/java/dev/cel/bundle/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ java_library(
3939
"//parser:macro",
4040
"//parser:parser_builder",
4141
"//runtime",
42-
"@@protobuf~//java/core",
4342
"@cel_spec//proto/cel/expr:expr_java_proto",
4443
"@maven//:com_google_code_findbugs_annotations",
4544
"@maven//:com_google_errorprone_error_prone_annotations",
4645
"@maven//:com_google_guava_guava",
46+
"@maven//:com_google_protobuf_protobuf_java",
4747
],
4848
)

bundle/src/test/java/dev/cel/bundle/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ java_library(
3333
"//parser:macro",
3434
"//runtime",
3535
"//runtime:unknown_attributes",
36-
"@@protobuf~//java/core",
3736
"@cel_spec//proto/cel/expr:expr_java_proto",
3837
"@cel_spec//proto/test/v1/proto2:test_all_types_java_proto",
3938
"@cel_spec//proto/test/v1/proto3:test_all_types_java_proto",
4039
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
4140
"@com_google_googleapis//google/type:type_java_proto",
4241
"@maven//:com_google_guava_guava",
4342
"@maven//:com_google_guava_guava_testlib",
43+
"@maven//:com_google_protobuf_protobuf_java",
4444
"@maven//:com_google_protobuf_protobuf_java_util",
4545
"@maven//:com_google_testparameterinjector_test_parameter_injector",
4646
"@maven//:com_google_truth_extensions_truth_proto_extension",

checker/src/main/java/dev/cel/checker/BUILD.bazel

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ java_library(
5252
"//common/types",
5353
"//common/types:cel_types",
5454
"//common/types:type_providers",
55-
"@@protobuf~//java/core",
5655
"@cel_spec//proto/cel/expr:expr_java_proto",
5756
"@maven//:com_google_errorprone_error_prone_annotations",
5857
"@maven//:com_google_guava_guava",
58+
"@maven//:com_google_protobuf_protobuf_java",
5959
"@maven//:org_jspecify_jspecify",
6060
],
6161
)
@@ -84,10 +84,10 @@ java_library(
8484
"//common/types:cel_types",
8585
"//common/types:message_type_provider",
8686
"//common/types:type_providers",
87-
"@@protobuf~//java/core",
8887
"@cel_spec//proto/cel/expr:expr_java_proto",
8988
"@maven//:com_google_errorprone_error_prone_annotations",
9089
"@maven//:com_google_guava_guava",
90+
"@maven//:com_google_protobuf_protobuf_java",
9191
],
9292
)
9393

@@ -103,9 +103,9 @@ java_library(
103103
"//common:compiler_common",
104104
"//common:options",
105105
"//common/types:type_providers",
106-
"@@protobuf~//java/core",
107106
"@cel_spec//proto/cel/expr:expr_java_proto",
108107
"@maven//:com_google_errorprone_error_prone_annotations",
108+
"@maven//:com_google_protobuf_protobuf_java",
109109
],
110110
)
111111

@@ -116,9 +116,9 @@ java_library(
116116
],
117117
deps = [
118118
"//:auto_value",
119-
"@@protobuf~//java/core",
120119
"@maven//:com_google_errorprone_error_prone_annotations",
121120
"@maven//:com_google_guava_guava",
121+
"@maven//:com_google_protobuf_protobuf_java",
122122
],
123123
)
124124

@@ -184,10 +184,10 @@ java_library(
184184
"//common/types:type_providers",
185185
"//parser:macro",
186186
"//parser:operator",
187-
"@@protobuf~//java/core",
188187
"@cel_spec//proto/cel/expr:expr_java_proto",
189188
"@maven//:com_google_errorprone_error_prone_annotations",
190189
"@maven//:com_google_guava_guava",
190+
"@maven//:com_google_protobuf_protobuf_java",
191191
"@maven//:org_jspecify_jspecify",
192192
],
193193
)

checker/src/test/java/dev/cel/checker/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ java_library(
1111
srcs = glob(["*Test.java"]),
1212
resources = ["//checker/src/test/resources:baselines"],
1313
deps = [
14-
"@@protobuf~//java/core",
14+
"@maven//:com_google_protobuf_protobuf_java",
1515
# "//java/com/google/testing/testsize:annotations",
1616
"//:auto_value",
1717
"//checker",

codelab/src/main/codelab/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ java_library(
3535
"//validator/validators:homogeneous_literal", # unuseddeps: keep
3636
"//validator/validators:regex", # unuseddeps: keep
3737
"//validator/validators:timestamp", # unuseddeps: keep
38-
"@@protobuf~//java/core", # unuseddeps: keep
3938
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto", # unuseddeps: keep
4039
"@maven//:com_google_guava_guava", # unuseddeps: keep
40+
"@maven//:com_google_protobuf_protobuf_java", # unuseddeps: keep
4141
"@maven//:com_google_protobuf_protobuf_java_util", # unuseddeps: keep
4242
],
4343
)

codelab/src/main/codelab/solutions/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ java_library(
3535
"//validator/validators:homogeneous_literal",
3636
"//validator/validators:regex",
3737
"//validator/validators:timestamp",
38-
"@@protobuf~//java/core",
3938
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
4039
"@maven//:com_google_guava_guava",
40+
"@maven//:com_google_protobuf_protobuf_java",
4141
"@maven//:com_google_protobuf_protobuf_java_util",
4242
],
4343
)

codelab/src/test/codelab/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ java_test(
2929
"//codelab",
3030
"//common",
3131
"//common/types",
32-
"@@protobuf~//java/core",
3332
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
3433
"@maven//:com_google_guava_guava",
34+
"@maven//:com_google_protobuf_protobuf_java",
3535
"@maven//:com_google_testparameterinjector_test_parameter_injector",
3636
"@maven//:junit_junit",
3737
],
@@ -60,9 +60,9 @@ java_test(
6060
"//:java_truth",
6161
"//codelab",
6262
"//common",
63-
"@@protobuf~//java/core",
6463
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
6564
"@maven//:com_google_guava_guava",
65+
"@maven//:com_google_protobuf_protobuf_java",
6666
"@maven//:com_google_testparameterinjector_test_parameter_injector",
6767
"@maven//:junit_junit",
6868
],
@@ -93,9 +93,9 @@ java_test(
9393
"//:java_truth",
9494
"//codelab",
9595
"//common",
96-
"@@protobuf~//java/core",
9796
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
9897
"@maven//:com_google_guava_guava",
98+
"@maven//:com_google_protobuf_protobuf_java",
9999
"@maven//:com_google_protobuf_protobuf_java_util",
100100
"@maven//:com_google_testparameterinjector_test_parameter_injector",
101101
"@maven//:junit_junit",

codelab/src/test/codelab/solutions/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ java_test(
2727
"//codelab:solutions",
2828
"//common",
2929
"//common/types",
30-
"@@protobuf~//java/core",
3130
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
3231
"@maven//:com_google_guava_guava",
32+
"@maven//:com_google_protobuf_protobuf_java",
3333
"@maven//:com_google_testparameterinjector_test_parameter_injector",
3434
"@maven//:junit_junit",
3535
],
@@ -56,9 +56,9 @@ java_test(
5656
"//:java_truth",
5757
"//codelab:solutions",
5858
"//common",
59-
"@@protobuf~//java/core",
6059
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
6160
"@maven//:com_google_guava_guava",
61+
"@maven//:com_google_protobuf_protobuf_java",
6262
"@maven//:com_google_testparameterinjector_test_parameter_injector",
6363
"@maven//:junit_junit",
6464
],
@@ -87,9 +87,9 @@ java_test(
8787
"//:java_truth",
8888
"//codelab:solutions",
8989
"//common",
90-
"@@protobuf~//java/core",
9190
"@com_google_googleapis//google/rpc/context:attribute_context_java_proto",
9291
"@maven//:com_google_guava_guava",
92+
"@maven//:com_google_protobuf_protobuf_java",
9393
"@maven//:com_google_protobuf_protobuf_java_util",
9494
"@maven//:com_google_testparameterinjector_test_parameter_injector",
9595
"@maven//:junit_junit",

0 commit comments

Comments
 (0)