fix(no-undefined-types): allow global prefixes; fixes #1566

Author: brettz9

docs/rules/no-undefined-types.md

@@ -1092,5 +1092,10 @@ const getValue = () => {};
  */
 const defineCustomElement = (tagName, component) => {
 };
+
+class Storage {
+ /** @type {globalThis.localStorage} */
+ #storage
+}
 ````
 

src/rules/noUndefinedTypes.js

@@ -20,6 +20,10 @@ const extraTypes = [
  'Array', 'Object', 'RegExp', 'Date', 'Function', 'Intl',
 ];
 
+const globalTypes = [
+ 'globalThis', 'global', 'window', 'self',
+];
+
 const typescriptGlobals = [
  // https://www.typescriptlang.org/docs/handbook/utility-types.html
  'Awaited',
@@ -470,6 +474,7 @@ export default iterateJsdoc(({
  parsedType,
  tag,
  } of tagsWithTypes) {
+ // eslint-disable-next-line complexity -- Refactor
  traverse(parsedType, (nde, parentNode) => {
  /**
  * @type {import('jsdoc-type-pratt-parser').NameResult & {
@@ -501,8 +506,10 @@ export default iterateJsdoc(({
  !importTags.includes(val) &&
  !extraTypes.includes(val) &&
  !typedefDeclarations.includes(val) &&
+ !globalTypes.includes(val) &&
  currNode && 'right' in currNode &&
- currNode.right?.type === 'JsdocTypeProperty') {
+ currNode.right?.type === 'JsdocTypeProperty'
+ ) {
  val = val + '.' + currNode.right.value;
  }
  } while (currNode?.type === 'JsdocTypeNamePath');

test/rules/assertions/noUndefinedTypes.js

@@ -1857,5 +1857,18 @@ export default /** @type {import('../index.js').TestCases} */ ({
  };
  `,
  },
+ {
+ code: `
+ class Storage {
+ /** @type {globalThis.localStorage} */
+ #storage
+ }
+ `,
+ languageOptions: {
+ globals: {
+ localStorage: 'readonly',
+ },
+ },
+ },
  ],
 });