Do not force err #1804
Merged
Do not force err #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Otherwise, a KeyError is raised if err has not been defined
| There is an example of misconfiguration that is rising this problem: https://github.com/fsspec/filesystem_spec/blob/master/fsspec/registry.py#L75-L77 |
baguenth approved these changes Mar 11, 2025
| This is fine; but the case of no error message means that the class in question should not be unimportable - because they are defined in this repo and have no further requirements. The specific import for async-wrapper is fixed in #1806 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Otherwise, a KeyError is raised if err has not been defined