feat: no-deprecated-api support removed api #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aladdin-add force-pushed the feat/no-deprecated-api-removed branch 3 times, most recently from fa74be9 to 74ab0d3 Compare 
scagood approved these changes Apr 15, 2024
scagood left a comment
scagood left a comment There was a problem hiding this comment.
Looks good to me!
I assume the error is the missing global? I wonder if there is a way to have this error without the global being defined?
| deprecated: | ||
| "{{name}} was deprecated since v{{version}}{{replace}}.", | ||
| removed: | ||
| "{{name}} was deprecated since v{{version}}, and removed in v{{removed}}.", |
There was a problem hiding this comment.
It could be worth including replace here still
Author
There was a problem hiding this comment.
yes, we can add it in another PR.
aladdin-add force-pushed the feat/no-deprecated-api-removed branch from 74ab0d3 to 42ac0a6 Compare 
Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
aladdin-add force-pushed the feat/no-deprecated-api-removed branch from c0c78f1 to 009f422 Compare 
This was referenced May 29, 2024
This was referenced Jun 27, 2024
This was referenced Aug 2, 2024
This was referenced Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.