fix(no-missing-import): Ignore node builtins in package.json imports (#346)

Author: scagood

lib/util/import-target.js

@@ -8,10 +8,17 @@ const { resolve } = require("path")
 const { isBuiltin } = require("node:module")
 const resolver = require("enhanced-resolve")
 
+const {
+ NodeBuiltinModules,
+} = require("../unsupported-features/node-builtins.js")
 const isTypescript = require("./is-typescript")
 const { getTSConfigForContext } = require("./get-tsconfig.js")
 const getTypescriptExtensionMap = require("./get-typescript-extension-map")
 
+const nodeBuiltinFallback = Object.keys(NodeBuiltinModules).map(
+ name => /** @type {const} */ ({ name, alias: false })
+)
+
 /**
  * @overload
  * @param {string[]} input
@@ -304,6 +311,8 @@ module.exports = class ImportTarget {
 
  extensionAlias,
  alias,
+
+ fallback: nodeBuiltinFallback,
  }
 
  const requireResolve = resolver.create.sync(this.resolverConfig)

tests/fixtures/no-missing/issue-285/package.json

@@ -0,0 +1,8 @@
+{
+ "imports": {
+ "#is-ip": {
+ "node": "net",
+ "browser": "is-ip"
+ }
+ }
+}

tests/lib/rules/no-missing-import.js

@@ -336,6 +336,12 @@ ruleTester.run("no-missing-import", rule, {
  code: "import plugin from 'eslint-plugin-n';",
  },
 
+ // imports alias
+ {
+ filename: fixture("issue-285/test.js"),
+ code: "import isIp from '#is-ip';",
+ },
+
  // import()
  ...(DynamicImportSupported
  ? [