Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 17, 2024

Fixes #446.

Doesn't include any options, as the internal core ESLint no-invalid-meta rule doesn't require anything beyond existence.

@aladdin-add
Copy link
Contributor

@JoshuaKGoldberg there is a few suggestions need to be addressed. friendly ping. :)

JoshuaKGoldberg and others added 2 commits April 23, 2024 17:24
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@JoshuaKGoldberg
Copy link
Contributor Author

D'oh, sorry! I completely missed the notification.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from bmish April 23, 2024 21:30
@bmish
Copy link
Member

bmish commented Apr 23, 2024

Looks like there are still conflicts.

@JoshuaKGoldberg
Copy link
Contributor Author

I'm finishing for the day, will fix the lint issue tomorrow.

@aladdin-add aladdin-add self-requested a review April 24, 2024 12:52
@aladdin-add
Copy link
Contributor

looks the ci was failing as the new release of eslint-doc-generator. I like to pin the version for better DX - as we don't have a lockfile.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from bmish April 24, 2024 20:10
@JoshuaKGoldberg JoshuaKGoldberg requested a review from bmish April 24, 2024 20:20
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 2370b46 into eslint-community:main Apr 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the require-meta-docs-recommended branch April 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants