Fix issue with space in database name, unicode names, replace STRING_SPLIT on XML alternative

Author: ktaranov

Scripts/IN_Memory_Example_2014.sql

@@ -1,21 +1,21 @@
--- https://docs.microsoft.com/en-us/sql/relational-databases/in-memory-oltp/overview-and-usage-scenarios
+-- https://docs.microsoft.com/en-us/sql/relational-databases/in-memory-oltp/overview-and-usage-scenarios
 USE master;
 GO
 
-IF OBJECT_ID('[TESTDB]', '') IS NOT NULL DROP DATABASE [TESTDB];
+IF OBJECT_ID('[ಠ ಠ]', '') IS NOT NULL DROP DATABASE [ಠ ಠ];
 GO
 
-CREATE DATABASE [TESTDB]
+CREATE DATABASE [ಠ ಠ]
  CONTAINMENT = NONE
  ON PRIMARY 
-( NAME = N'TESTDB',  FILENAME = N'd:\MSSQL\MSSQL12.MSSQLSERVER\MSSQL\DATA\TESTDB.mdf', SIZE = 128MB, MAXSIZE = UNLIMITED, FILEGROWTH = 128MB), 
-FILEGROUP [TESTDB] CONTAINS MEMORY_OPTIMIZED_DATA DEFAULT
-( NAME = N'TESTDB_mod', FILENAME = N'd:\MSSQL\MSSQL12.MSSQLSERVER\MSSQL\DATA\TESTDB_mod', MAXSIZE = UNLIMITED)
+( NAME = N'ಠ ಠ', FILENAME = N'd:\MSSQL\MSSQL12.MSSQLSERVER\MSSQL\DATA\ಠ ಠ.mdf', SIZE = 64MB, MAXSIZE = UNLIMITED, FILEGROWTH = 64MB), 
+FILEGROUP [ಠ ಠ] CONTAINS MEMORY_OPTIMIZED_DATA DEFAULT
+( NAME = N'TESTDB_mod', FILENAME = N'd:\MSSQL\MSSQL12.MSSQLSERVER\MSSQL\DATA\ಠ ಠ_mod', MAXSIZE = UNLIMITED)
  LOG ON 
-( NAME = N'TESTDB_log', FILENAME = N'd:\MSSQL\MSSQL12.MSSQLSERVER\MSSQL\DATA\TESTDB_log.ldf', SIZE = 128MB, MAXSIZE = 2048MB, FILEGROWTH = 128MB)
+( NAME = N'TESTDB_log', FILENAME = N'd:\MSSQL\MSSQL12.MSSQLSERVER\MSSQL\DATA\ಠ ಠ_log.ldf', SIZE = 64MB, MAXSIZE = 2048MB, FILEGROWTH = 64MB)
 GO
 
-USE TESTDB;
+USE [ಠ ಠ];
 GO
 -- configure recommended DB option
  ALTER DATABASE CURRENT SET MEMORY_OPTIMIZED_ELEVATE_TO_SNAPSHOT=ON

Scripts/IN_Memory_Example_2017.sql

@@ -1,17 +1,17 @@
--- https://docs.microsoft.com/en-us/sql/relational-databases/in-memory-oltp/overview-and-usage-scenarios
+-- https://docs.microsoft.com/en-us/sql/relational-databases/in-memory-oltp/overview-and-usage-scenarios
 USE master;
 
-CREATE DATABASE [TESTDB]
+CREATE DATABASE [ಠ ಠ]
  CONTAINMENT = NONE
  ON PRIMARY 
-( NAME = N'TESTDB', FILENAME = N'C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\DATA\TESTDB.mdf', SIZE = 64MB, MAXSIZE = UNLIMITED, FILEGROWTH = 64MB), 
-FILEGROUP [TESTDB] CONTAINS MEMORY_OPTIMIZED_DATA DEFAULT
-( NAME = N'TESTDB_mod', FILENAME = N'C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\DATA\TESTDB_mod', MAXSIZE = UNLIMITED)
+( NAME = N'ಠ ಠ', FILENAME = N'C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\DATA\ಠ ಠ.mdf', SIZE = 64MB, MAXSIZE = UNLIMITED, FILEGROWTH = 64MB), 
+FILEGROUP [ಠ ಠ] CONTAINS MEMORY_OPTIMIZED_DATA DEFAULT
+( NAME = N'TESTDB_mod', FILENAME = N'C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\DATA\ಠ ಠ_mod', MAXSIZE = UNLIMITED)
  LOG ON 
-( NAME = N'TESTDB_log', FILENAME = N'C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\DATA\TESTDB_log.ldf', SIZE = 64MB, MAXSIZE = 2048MB, FILEGROWTH = 64MB)
+( NAME = N'TESTDB_log', FILENAME = N'C:\Program Files\Microsoft SQL Server\MSSQL14.MSSQLSERVER\MSSQL\DATA\ಠ ಠ_log.ldf', SIZE = 64MB, MAXSIZE = 2048MB, FILEGROWTH = 64MB)
 GO
 
-USE [TESTDB]
+USE [ಠ ಠ];
 GO
 
 -- configure recommended DB option

Stored_Procedure/sp_BlitzInMemoryOLTP.sql

@@ -7,7 +7,7 @@ GO
 
 ALTER PROCEDURE dbo.sp_BlitzInMemoryOLTP(
  @instanceLevelOnly BIT = 0
- , @dbName NVARCHAR(4000) = 'ALL'
+ , @dbName NVARCHAR(4000) = N'ALL'
  , @debug BIT = 0
 )
 /*
@@ -91,7 +91,7 @@ AS BEGIN TRY
  */
 
  IF OBJECT_ID('tempdb..#inmemDatabases') IS NOT NULL DROP TABLE #inmemDatabases;
- SELECT name
+ SELECT QUOTENAME(name) AS name
  , database_id
  , ROW_NUMBER() OVER (ORDER BY name ASC) AS rowNumber
  INTO #inmemDatabases
@@ -110,7 +110,7 @@ AS BEGIN TRY
  END;
 
  IF (@dbName IS NOT NULL AND @dbName <> 'ALL') 
- AND (NOT EXISTS (SELECT 1 FROM #inmemDatabases WHERE name = @dbName) AND @instanceLevelOnly = 0)
+ AND (NOT EXISTS (SELECT 1 FROM #inmemDatabases WHERE name = QUOTENAME(@dbName)) AND @instanceLevelOnly = 0)
  BEGIN
  SET @errorMessage = '@dbName not found in sys.databases';
  THROW 55002, @errorMessage, 1;
@@ -160,12 +160,18 @@ AS BEGIN TRY
  FROM @loadedModules
  WHERE rowNumber = @moduleCounter;
 
+ DECLARE @xml XML
+ , @delimiter NVARCHAR(10);
+ SET @delimiter = '_';
+ SET @xml = CAST(('<X>'+REPLACE(@loadedModuleName, @delimiter, '</X><X>')+'</X>') AS XML);
+
  INSERT #moduleSplit
  (
  value
  )
- SELECT value
- FROM STRING_SPLIT(@loadedModuleName, '_');
+ SELECT C.value('.', 'NVARCHAR(1000)') AS value FROM @xml.nodes('X') as X(C);
+ --SELECT value
+ --FROM STRING_SPLIT(@loadedModuleName, '_');
 
  SELECT @moduleCounter += 1;
 
@@ -204,7 +210,7 @@ AS BEGIN TRY
  (
  @crlf
  ,'SELECT DISTINCT '
- , ''''
+ , 'N'''
  , name
  , ''' AS databaseName,' + @crlf
  , database_id
@@ -233,7 +239,7 @@ AS BEGIN TRY
  ,'FROM InMemDatabases '
  ,@crlf
  ,'INNER JOIN sys.databases ON '
- ,'sys.databases.name = InMemDatabases.databaseName;'
+ ,'QUOTENAME(sys.databases.name) = InMemDatabases.databaseName;'
  );
 
  IF @debug = 1
@@ -308,7 +314,7 @@ AS BEGIN TRY
  'SELECT TOP 1'
  ,'''Memory optimized tables'''
  , ' AS objects,'
- , ''''
+ , ' N'''
  ,dbName
  ,''' AS databaseName'
  ,', b.name AS tableName 
@@ -350,9 +356,9 @@ AS BEGIN TRY
  SELECT @sql = CONCAT(
  'SELECT '
  ,'''List indexes on memory-optimized tables in this database'' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
- ,'''' 
+ ,''''
  ,' AS databaseName
  ,t.name AS tableName
  ,i.name AS indexName
@@ -414,7 +420,7 @@ AS BEGIN TRY
  ,'''avg_chain_length for HASH indexes'''
  ,' AS objects,'''
  ,dbName
- ,'''' 
+ ,''''
  ,' AS databaseName'
  ,', sch.name AS [Schema] '
  ,', t.name AS tableName 
@@ -460,8 +466,8 @@ AS BEGIN TRY
 
  SELECT @sql = CONCAT(
  'SELECT '
- ,'''Number of indexes per table'' AS objects,' 
- ,''''
+ ,'''Number of indexes per table'' AS objects,'
+ ,' N'''
  ,dbName
  ,''''
  ,' AS databaseName
@@ -502,7 +508,7 @@ AS BEGIN TRY
  */
  SELECT @sql = CONCAT(
  'SELECT ''Natively compiled modules'' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
  ,''''
  ,' AS databaseName
@@ -555,7 +561,7 @@ AS BEGIN TRY
  )'
  SELECT @sql += CONCAT(
  'SELECT ''Loaded natively modules'' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
  ,''''
  ,' AS databaseName
@@ -586,9 +592,9 @@ AS BEGIN TRY
 
  SELECT @sql = CONCAT(
  'SELECT ''Count of Natively compiled modules'' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
- ,''''
+ ,' N'''
  ,' AS databaseName
  , COUNT(*) AS [Number of modules]
  FROM '
@@ -622,7 +628,7 @@ AS BEGIN TRY
  AS
  (
  SELECT '
- ,''''
+ ,'N'''
  ,dbName
  ,'''' 
  ,' AS databaseName'
@@ -689,7 +695,7 @@ AS BEGIN TRY
  SELECT @sql = CONCAT(
  'SELECT DISTINCT '
  ,'''LOB/Off-row data '' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
  ,'''' 
  ,' AS databaseName'
@@ -736,7 +742,7 @@ AS BEGIN TRY
  SELECT @sql = CONCAT(
  'SELECT '
  ,'''Database layout'' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
  ,'''' 
  ,' AS databaseName'
@@ -790,7 +796,7 @@ AS BEGIN TRY
  )
  SELECT 
  ''Container details by container name'' AS object,'
- ,''''
+ ,' N'''
  ,dbName
  ,'''' 
  ,' AS databaseName
@@ -833,7 +839,7 @@ AS BEGIN TRY
  )
  SELECT 
  ''Container details by fileType and fileState'' AS object,'
- ,''''
+ ,' N'''
  ,dbName
  ,'''' 
  ,' AS databaseName
@@ -880,7 +886,7 @@ AS BEGIN TRY
  )
  SELECT '
  ,'''Container file details'' AS object,'
- ,''''
+ ,' N'''
  ,dbName
  ,'''' 
  ,' AS databaseName
@@ -913,7 +919,7 @@ AS BEGIN TRY
  SELECT @sql = CONCAT(
  'SELECT '
  ,'''Memory optimized table types'' AS objects,'
- ,''''
+ ,' N'''
  ,dbName
  ,''' AS databaseName,' 
  ,'SCHEMA_NAME(tt.schema_id) AS [Schema]