ratelimitprocessor: Wrap error with code for 429 #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Wraps the error returned by the rate limiter with the grpc code library to ensure that the code is propagated to the client. For non 5xx errors, the code is set to `codes.ResourceExhausted`, which is the appropriate code for rate limiting errors. Part of elastic/hosted-otel-collector#991 Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
axw approved these changes Jul 11, 2025
Contributor
| I see @axw already approved, but I already ran a quick test, and now it returns 429. From 2025-07-11T07:42:51.464Z error internal/base_exporter.go:117 Exporting failed. Rejecting data. Try enabling sending_queue to survive temporary failures. {"resource": {"service.instance.id": "3d49f0e7-eb0e-47ca-8002-edb4abd0e5dd", "service.name": "/ko-app/loadgen", "service.version": "0.0.1"}, "otelcol.component.id": "otlp", "otelcol.component.kind": "exporter", "otelcol.signal": "traces", "error": "not retryable error: Permanent error: rpc error: code = Code(429) desc = 429 Too Many Requests", "rejected_items": 5} go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*BaseExporter).Send go.opentelemetry.io/collector/exporter@v0.129.0/exporterhelper/internal/base_exporter.go:117 go.opentelemetry.io/collector/exporter/exporterhelper.NewTracesRequest.newConsumeTraces.func1 go.opentelemetry.io/collector/exporter@v0.129.0/exporterhelper/traces.go:193 go.opentelemetry.io/collector/consumer.ConsumeTracesFunc.ConsumeTraces go.opentelemetry.io/collector/consumer@v1.35.0/traces.go:27 go.opentelemetry.io/collector/processor/processorhelper.NewTraces.func1 go.opentelemetry.io/collector/processor/processorhelper@v0.129.0/traces.go:66 go.opentelemetry.io/collector/consumer.ConsumeTracesFunc.ConsumeTraces go.opentelemetry.io/collector/consumer@v1.35.0/traces.go:27 go.opentelemetry.io/collector/consumer.ConsumeTracesFunc.ConsumeTraces go.opentelemetry.io/collector/consumer@v1.35.0/traces.go:27 go.opentelemetry.io/collector/internal/fanoutconsumer.(*tracesConsumer).ConsumeTraces go.opentelemetry.io/collector/internal/fanoutconsumer@v0.129.0/traces.go:60 github.com/elastic/opentelemetry-collector-components/receiver/loadgenreceiver.(*tracesGenerator).Start.func1 github.com/elastic/opentelemetry-collector-components/receiver/loadgenreceiver@v0.0.0-00010101000000-000000000000/traces.go:130QQ: does it says "not retryable error: Permanent error" because the OTLP exporter in |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Wraps the error returned by the rate limiter with the grpc code library to ensure that the code is propagated to the client. For non 5xx errors, the code is set to
codes.ResourceExhausted, which is the appropriate code for rate limiting errors.Part of elastic/hosted-otel-collector#991