Skip to content

Conversation

@nagilson
Copy link
Member

Please see: #49686, which was initially closed. We decided to redo that PR. That's because the ACR is fixed but now the docker versions of the CI machines are out of date. This is causing a high rate of sporadic failures and blocking most of the repo. There is an internal ticket from the engineering system team to update these images but it will take them some time.

nagilson added 3 commits July 8, 2025 10:17
These tests have a high number of failures documented at (Skip = "dotnet#49502"). The registry issue may not be solved until funding is increased or engineering effort is made to handle this case better and not run the tests. Merge
we will still find this in search and with the history of test-debt label. Lets just do this temporary workaround
Copilot AI review requested due to automatic review settings July 14, 2025 18:38
@nagilson nagilson requested review from a team as code owners July 14, 2025 18:38
@nagilson nagilson changed the base branch from main to release/9.0.1xx July 14, 2025 18:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables flaky registry- and Docker-related container tests to unblock CI until images are updated, updates framework filters in ILLink publish tests, adds new unit tests for retry logic in Registry.DownloadBlobAsync, and adds extra inline data entries in trusted-roots tests.

  • Disable most DockerAvailableFact/DockerAvailableTheory tests by adding Skip with a link to issue 49502.
  • Update ILLink tests to only run on Net8Plus targets instead of SupportedTfms.
  • Introduce two new retry-related unit tests in RegistryTests.cs and add missing certificate fingerprints in trusted-roots tests.

Reviewed Changes

Copilot reviewed 167 out of 168 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/trustedroots.Tests/GivenTimestampingCtlFile.cs Added new certificate fingerprint InlineData entries.
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs Switched several tests to use Net8Plus MemberData instead of SupportedTfms.
test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs Refactored dependency creation to parallel loops and new list accumulation.
test/Microsoft.NET.Build.Containers.UnitTests/RegistryTests.cs Added two new async unit tests for retry behavior in DownloadBlobAsync.
test/Microsoft.NET.Build.Containers.UnitTests/DockerDaemonTests.cs Skipped a Docker availability test due to outdated Docker on CI machines.
test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs Marked end-to-end container tests as skipped with reference to issue 49502.
Files not reviewed (1)
  • src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)

test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs:38

  • The new list dependencyPackageReferences is never populated inside the Parallel.ForEach. You need to add each dependencyPackageReference to this list (e.g., dependencyPackageReferences.Add(dependencyPackageReference)), and because it’s parallel, consider using a thread-safe collection or lock around the add.
 var dependencyPackageReferences = new List<TestPackageReference>(); 

test/Microsoft.NET.Build.Containers.IntegrationTests/CreateNewImageTests.cs:55

  • This line is invalid syntax. It looks like an attribute invocation was accidentally inserted into code. It should reference a static property (e.g. DockerAvailableFactAttribute.LocalRegistry), not call the attribute.
 task.LocalRegistry = DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")Attribute.LocalRegistry; 
@nagilson
Copy link
Member Author

/backport to release/9.0.3xx

@nagilson nagilson enabled auto-merge July 14, 2025 18:45
@github-actions
Copy link
Contributor

Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/16275142795

@nagilson
Copy link
Member Author

/backport to main

@github-actions
Copy link
Contributor

@nagilson
Copy link
Member Author

/backport to release/8.0.3xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/16299438266

@github-actions
Copy link
Contributor

@nagilson backporting to "main" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch Applying: Disable flakey container registry tests Using index info to reconstruct a base tree... M	test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs Falling back to patching base and 3-way merge... Auto-merging test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs CONFLICT (content): Merge conflict in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config set advice.mergeConflict false" Patch failed at 0001 Disable flakey container registry tests Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@nagilson backporting to "release/8.0.3xx" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch Applying: Disable flakey container registry tests Using index info to reconstruct a base tree... A	test/Microsoft.NET.Build.Containers.IntegrationTests/DockerRegistryTests.cs A	test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs Falling back to patching base and 3-way merge... Auto-merging src/Tests/Microsoft.NET.Build.Containers.IntegrationTests/DockerRegistryTests.cs CONFLICT (modify/delete): test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs deleted in HEAD and modified in Disable flakey container registry tests. Version Disable flakey container registry tests of test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs left in tree. error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config set advice.mergeConflict false" Patch failed at 0001 Disable flakey container registry tests Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@nagilson nagilson merged commit 4a12a5d into dotnet:release/9.0.1xx Jul 15, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants