- Notifications
You must be signed in to change notification settings - Fork 1.2k
Disable Registry Related Containers Tests #49773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Registry Related Containers Tests #49773
Conversation
These tests have a high number of failures documented at (Skip = "dotnet#49502"). The registry issue may not be solved until funding is increased or engineering effort is made to handle this case better and not run the tests. Merge
we will still find this in search and with the history of test-debt label. Lets just do this temporary workaround
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables flaky registry- and Docker-related container tests to unblock CI until images are updated, updates framework filters in ILLink publish tests, adds new unit tests for retry logic in Registry.DownloadBlobAsync, and adds extra inline data entries in trusted-roots tests.
- Disable most
DockerAvailableFact/DockerAvailableTheorytests by addingSkipwith a link to issue 49502. - Update ILLink tests to only run on
Net8Plustargets instead ofSupportedTfms. - Introduce two new retry-related unit tests in
RegistryTests.csand add missing certificate fingerprints in trusted-roots tests.
Reviewed Changes
Copilot reviewed 167 out of 168 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/trustedroots.Tests/GivenTimestampingCtlFile.cs | Added new certificate fingerprint InlineData entries. |
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs | Switched several tests to use Net8Plus MemberData instead of SupportedTfms. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs | Refactored dependency creation to parallel loops and new list accumulation. |
| test/Microsoft.NET.Build.Containers.UnitTests/RegistryTests.cs | Added two new async unit tests for retry behavior in DownloadBlobAsync. |
| test/Microsoft.NET.Build.Containers.UnitTests/DockerDaemonTests.cs | Skipped a Docker availability test due to outdated Docker on CI machines. |
| test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs | Marked end-to-end container tests as skipped with reference to issue 49502. |
Files not reviewed (1)
- src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)
test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs:38
- The new list
dependencyPackageReferencesis never populated inside theParallel.ForEach. You need to add eachdependencyPackageReferenceto this list (e.g.,dependencyPackageReferences.Add(dependencyPackageReference)), and because it’s parallel, consider using a thread-safe collection or lock around the add.
var dependencyPackageReferences = new List<TestPackageReference>(); test/Microsoft.NET.Build.Containers.IntegrationTests/CreateNewImageTests.cs:55
- This line is invalid syntax. It looks like an attribute invocation was accidentally inserted into code. It should reference a static property (e.g.
DockerAvailableFactAttribute.LocalRegistry), not call the attribute.
task.LocalRegistry = DockerAvailableFact(Skip = "https://github.com/dotnet/sdk/issues/49502")Attribute.LocalRegistry; | /backport to release/9.0.3xx |
| Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/16275142795 |
…nagilson/sdk into nagilson/disable-containers-reg
test/Microsoft.NET.Build.Containers.IntegrationTests/CreateNewImageTests.cs Outdated Show resolved Hide resolved
test/Microsoft.NET.Build.Containers.IntegrationTests/CreateNewImageTests.cs Outdated Show resolved Hide resolved
| /backport to main |
| Started backporting to main: https://github.com/dotnet/sdk/actions/runs/16299433574 |
| /backport to release/8.0.3xx |
| Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/16299438266 |
| @nagilson backporting to "main" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch Applying: Disable flakey container registry tests Using index info to reconstruct a base tree... M test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs Falling back to patching base and 3-way merge... Auto-merging test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs CONFLICT (content): Merge conflict in test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config set advice.mergeConflict false" Patch failed at 0001 Disable flakey container registry tests Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
| @nagilson backporting to "release/8.0.3xx" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch Applying: Disable flakey container registry tests Using index info to reconstruct a base tree... A test/Microsoft.NET.Build.Containers.IntegrationTests/DockerRegistryTests.cs A test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs Falling back to patching base and 3-way merge... Auto-merging src/Tests/Microsoft.NET.Build.Containers.IntegrationTests/DockerRegistryTests.cs CONFLICT (modify/delete): test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs deleted in HEAD and modified in Disable flakey container registry tests. Version Disable flakey container registry tests of test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs left in tree. error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config set advice.mergeConflict false" Patch failed at 0001 Disable flakey container registry tests Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Please see: #49686, which was initially closed. We decided to redo that PR. That's because the ACR is fixed but now the docker versions of the CI machines are out of date. This is causing a high rate of sporadic failures and blocking most of the repo. There is an internal ticket from the engineering system team to update these images but it will take them some time.