Upgrade scancode to 32.4.0 and revert pinning of click #49576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
akoeplinger approved these changes Jun 30, 2025
mthalman reviewed Jul 7, 2025
Comment on lines 24 to 25
| src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/build/deb-package-tool/templates/debian/copyright|unknown-license-reference | ||
| src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/build/rpm_templates/copyright|unknown-license-reference |
Member
There was a problem hiding this comment.
I would categorize these as false positives since they aren't true license references.
| # Windows installer files that have a reference to a URL for license | ||
| src/aspnetcore/src/Installers/Windows/**/*.wxl|unknown-license-reference | ||
| src/aspnetcore/src/Installers/Windows/**/*.wxs|unknown-license-reference | ||
| src/aspnetcore/src/Installers/Debian/tools/templates/debian/copyright|unknown-license-reference |
Member
There was a problem hiding this comment.
Should be categorized as false positive.
Comment on lines 7 to 10
| { | ||
| "path": "src/application-insights/WEB/ThirdPartyNotices.txt", | ||
| "detected_license_expression": "(unknown-license-reference AND bsd-new) AND mit AND ms-pl AND apache-2.0 AND (cc-by-3.0-us AND cc-by-3.0 AND mit) AND ms-rl" | ||
| } |
Member
There was a problem hiding this comment.
This should be removed. The unknown-license-reference should be defined as a false positive in the exclusions file.
Member
| Please update dotnet/dotnet#1401 and dotnet/installer#20486 based on the changes to make here. |
mthalman approved these changes Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#5208
New release of scancode is available, revert pinning of click package.