Replaced failing functional tests with failing cucumber scenarios. Portlets are broken (can't be edited or deleted).

Author: peakpg

features/portlets.feature

@@ -28,4 +28,34 @@ Feature: Portlets
  When I go to the content library
  And follow "Portlet"
  Then I should see the following content:
- | A new portlet |
+ | A new portlet |
+
+ # Portlets aren't deleting or updating due to errors with dynamic attributes.
+ Scenario: Deleting a portlet
+ Given I am logged in as a Content Editor
+ And there is a "Portlet" with:
+ | name | template |
+ | A new portlet | Hello World |
+ When I delete that portlet
+ And I go to the content library
+ And I click on "Portlet"
+ And I should not see "A new portlet"
+ When I view that portlet
+ Then the response should be 500
+
+ # Portlets aren't deleting or updating due to errors with dynamic attributes.
+ Scenario: Editing a portlet
+ Given I am logged in as a Content Editor
+ And there is a "Portlet" with:
+ | name | template |
+ | A new portlet | Hello World |
+ When I edit that portlet
+ And fill in "Name" with "New Name"
+ And fill in "Template" with "New World"
+ And I click on "Save"
+ Then I should see the following content:
+ | View Portlet 'New Name' |
+ | New World |
+ And I should not see the following content:
+ | A new portlet |
+ | Hello World |

features/step_definitions/content_pages_steps.rb

@@ -4,6 +4,7 @@
  assert page.has_content?(page_title)
 end
 
+
 Given /^I am logged in as a Content Editor$/ do
  visit '/cms'
  fill_in 'login', :with => 'cmsadmin'
@@ -58,4 +59,8 @@
 end
 Then /^I should see a list of selectable content types$/ do
  pending
+end
+
+When /^I click on "([^"]*)"$/ do |name|
+ click_on name
 end

features/step_definitions/data_steps.rb

@@ -4,7 +4,11 @@
  end
 end
 
-
+When /^I should not see the following content:$/ do |table|
+ table.raw.each do |row|
+ refute page.has_content?(row[0]), "Found #{row[0]}' on the page when it was not expected to be there."
+ end
+end
 
 
 # Creates a CMS::FileBlock
@@ -30,9 +34,9 @@
 # | name | content |
 # | A | B |
 When /^there is a "([^"]*)" with:$/ do |model_class, table|
- Factory(model_class.underscore.to_sym, table.hashes.first)
+ @subject = Factory(model_class.underscore.to_sym, table.hashes.first)
 end
 
 When /^there is a page with:$/ do |table|
  Factory(:public_page, { :publish_on_save=>true }.merge(table.hashes.first))
-end
+end

features/step_definitions/portlets_steps.rb

@@ -1 +1,11 @@
-# Steps for portlet.features
+# Steps for portlet.features
+When /^I delete that portlet$/ do
+ # cms_portlet_path(@subject) seemed to create a wrong path: /cms/portlets.1 rather than the below statement
+ page.driver.delete "/cms/portlets/#{@subject.id}"
+end
+When /^I view that portlet$/ do
+ visit cms_portlet_path(@subject)
+end
+When /^I edit that portlet$/ do
+ visit edit_cms_portlet_path(@subject)
+end

test/functional/cms/portlets_controller_test.rb

@@ -15,13 +15,6 @@ def test_index
  assert_select "#dynamic_portlet_#{@block.id}"
  end
 
- def test_index_does_not_show_deleted_portlets
- @block.destroy
- get :index
- assert_response :success
- assert_select "#dynamic_portlet_#{@block.id}", 0
- end
-
  def test_show
  get :show, :id => @block.id
  assert_response :success
@@ -41,12 +34,6 @@ def test_edit
  assert_select "h1", "Edit Portlet 'V1'"
  end
 
- def test_destroy
- delete :destroy, :id => @block.id
- assert_redirected_to cms_portlets_path
- assert_raise(ActiveRecord::RecordNotFound) { DynamicPortlet.find(@block.id) }
- end
-
  def test_usages
  @page = Factory(:page, :section => root_section, :name => "Test Page", :path => "test")
  @page.create_connector(@block, "main")

test/unit/behaviors/dynamic_attributes_test.rb

@@ -65,14 +65,6 @@ def setup
  assert_equal("Paper", @thing.description)
  end
 
- #test "Always respond_to something=" do
- # assert_equal(true, Thing.respond_to?(:price=))
- # assert_equal true, @thing.respond_to?(:price=)
- # assert(Thing.respond_to?(:a=))
- # assert_equal(false, @thing.respond_to?(:price))
- # assert_equal(false, @thing.respond_to?("=".to_sym))
- #end
- 
  test "can bulk set persistent properties during construction" do
  mineral = Thing.new(:description=>"Rock")
  mineral.save!

test/unit/models/portlet_test.rb

@@ -20,6 +20,28 @@ class EditablePortlet < Cms::Portlet
 
 class PortletTest < ActiveSupport::TestCase
 
+ def setup
+ @portlet = Factory(:portlet)
+
+ end
+ test "destroy should mark a portlet as deleted" do
+ @portlet.destroy
+ @portlet.reload!
+ Cms::Portlet.find(@portlet.id)
+ assert_raise(ActiveRecord::RecordNotFound){
+ Cms::Portlet.find(@portlet.id)
+ }
+ end
+
+ test "update_attributes" do
+ @portlet.update_attributes(:b => "whatever")
+ assert_equal "whatever", @portlet.b
+ end
+
+ test "attributes=" do
+ @portlet.attributes=({:b => "b"})
+ assert_equal "b", @portlet.b
+ end
  def test_dynamic_attributes
  portlet = DynamicPortlet.create(:name => "Test", :foo => "FOO")
  assert_equal "FOO", Cms::Portlet.find(portlet.id).foo

upgrading_to_3_1.txt

@@ -28,14 +28,13 @@ http://freelancing-gods.com/posts/combustion_better_rails_engine_testing
 Start HERE
 ---------
 
+Replace integration tests with cucumber features.
 
-Start working on functional tests. There are several broken file upload based on things which are likely brittle tests
 
-Finishing tests:
-
-2. Replace any broken functional tests with a cucumber test.
-
-rake test:functionals
- test/functional/cms/portlets_controller_test.rb:47:in `test_destroy']:
-Unit tests leave seed data in DB.
+# Problem: Portlets cannot be deleted or updated
+Why: update_attributes is calling assign_attributes, which doesn't appear to be present on instances of a portlet for reasons I don't understand. Dynamic attributes
+ are complicating matters again.
 
+Other alternatives:
+1. Continue to patch dynamic attributes
+2. Rip it out, replace with something like 'json_record' (https://github.com/bdurand/json_record) which would allow us to store in a single column.