Skip to content

Stop using Internet#username() interally #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Stop using Internet#username() interally #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/net/datafaker/providers/base/Internet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public String username() {
}

public String emailAddress() {
return emailAddress(username());
return emailAddress(faker.credentials().username());
}

/**
Expand Down Expand Up @@ -76,7 +76,7 @@ public String emailAddress(String name) {
}

public String safeEmailAddress() {
return safeEmailAddress(username());
return safeEmailAddress(faker.credentials().username());
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/datafaker/providers/base/Name.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,6 @@ public String title() {
@Deprecated(since = "2.5.0", forRemoval = true)
@SuppressWarnings("removal")
public String username() {
return faker.internet().username();
return faker.credentials().username();
}
}
Loading